Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tools): ✨ add YouTube Video transcript fetching #5034

Closed

Conversation

patryk20120
Copy link
Contributor

Description

Adding a tool for fetching transcript of a YouTube video.

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Jun 7, 2024
@crazywoola crazywoola requested a review from takatost June 7, 2024 23:37
@takatost takatost requested a review from Yeuoly June 9, 2024 04:23
@takatost
Copy link
Collaborator

takatost commented Jun 9, 2024

Hey @Yeuoly, do you think it's better to put this under the YouTube provider or have it as a separate provider youtubetranscript?

@patryk20120
Copy link
Contributor Author

Hey @Yeuoly, do you think it's better to put this under the YouTube provider or have it as a separate provider youtubetranscript?

I think it is impossible to put this under YouTube provider, as YouTube provider needs an authorization but this tool does not need it.

@takatost
Copy link
Collaborator

takatost commented Jun 9, 2024

Hey @Yeuoly, do you think it's better to put this under the YouTube provider or have it as a separate provider youtubetranscript?

I think it is impossible to put this under YouTube provider, as YouTube provider needs an authorization but this tool does not need it.

This is indeed a problem. 🤔

@patryk20120
Copy link
Contributor Author

patryk20120 commented Jun 9, 2024

Hey @Yeuoly, do you think it's better to put this under the YouTube provider or have it as a separate provider youtubetranscript?

I think it is impossible to put this under YouTube provider, as YouTube provider needs an authorization but this tool does not need it.

This is indeed a problem. 🤔

Also wanted to do that until I found this out

@Yeuoly
Copy link
Collaborator

Yeuoly commented Jun 9, 2024

Yes, this is what I mentioned before. We might need a provider group to aggregate all brand-related providers, such as Google, SerpAPI, and Google Mail, together.

@patryk20120
Copy link
Contributor Author

Yes, this is what I mentioned before. We might need a provider group to aggregate all brand-related providers, such as Google, SerpAPI, and Google Mail, together.

Would be pleasure to collaborate in this field

@Yeuoly
Copy link
Collaborator

Yeuoly commented Jun 9, 2024

Yes, this is what I mentioned before. We might need a provider group to aggregate all brand-related providers, such as Google, SerpAPI, and Google Mail, together.

Would be pleasure to collaborate in this field

It looks like we need some UI design work on the frontend. On the backend, we just need to add a brand field to the YAML file. Can you help with that?

@patryk20120
Copy link
Contributor Author

Yes, this is what I mentioned before. We might need a provider group to aggregate all brand-related providers, such as Google, SerpAPI, and Google Mail, together.

Would be pleasure to collaborate in this field

It looks like we need some UI design work on the frontend. On the backend, we just need to add a brand field to the YAML file. Can you help with that?

Do you mean backend or both? I notice that you have a very good UI developer or principals, I would like to not destroy that :) If you send me the UX project I can implement it both on front and back ends

@crazywoola crazywoola requested a review from laipz8200 June 13, 2024 09:25
@laipz8200
Copy link
Member

Yes, this is what I mentioned before. We might need a provider group to aggregate all brand-related providers, such as Google, SerpAPI, and Google Mail, together.

Would be pleasure to collaborate in this field

It looks like we need some UI design work on the frontend. On the backend, we just need to add a brand field to the YAML file. Can you help with that?

Do you mean backend or both? I notice that you have a very good UI developer or principals, I would like to not destroy that :) If you send me the UX project I can implement it both on front and back ends

I think she's talking about the backend. If our API includes a 'brand' field, we can start designing and completing the frontend work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants