Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api/migrations): apply ruff reformatting in db migrations #7592

Closed

Conversation

bowenliang123
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

apply ruff reformat in api/migration

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@bowenliang123 bowenliang123 marked this pull request as ready for review August 23, 2024 15:13
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 23, 2024
@bowenliang123 bowenliang123 changed the title chore(api/migraion): apply ruff reformatting in db migrations chore(api/migrations): apply ruff reformatting in db migrations Aug 23, 2024
@laipz8200
Copy link
Member

These code is auto-generated by Alembic. I think it would be better to leave it as is and keep this directory excluded.

@bowenliang123
Copy link
Contributor Author

Alright. Closing this PR.

@bowenliang123 bowenliang123 deleted the reformat-migration branch August 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants