SCF IndexSwitch to nested If-Else #7670
Merged
+277
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#7669 supports nested also referencing calyxir/calyx#1177 and calyxir/calyx#1423 if they are relevant |
|
This needs test programs before we can merge it. Please add some tests and tag me when that's done. |
Thanks for the reminder, I'll change and push again soon! |
|
I think I should move to directory Also tagging code owners for their opinions @mikeurbach @mortbopet , thanks! |
|
Yeah, I think that sounds like a good idea! |
|
Let's add tests before making @mortbopet or @mikeurbach review this PR... |
jiahanxie353
force-pushed
the
index-switch-to-if
branch
from
dfc0671
to
577722d
Compare
|
bumping this |
cgyurgyik
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
LGTM, one tiny suggestion.
This transform is meant for dialects that inherently does not have a switch control statement (like Calyx)
Another suggestion: make this a bit more descriptive (and declarative) so readers can more easily capture what's going on, e.g.:
Transforms scf.switch to a series of scf.if statements. This is necessary for dialects that don't support switch statements, e.g., Calyx. An example:
%0 = scf.index_switch %cond -> i32
case 0 { ... }
case 1 { ... }
...
=>
%c0 = arith.cmpi eq %0, 0
%c1 = arith.cmpi eq %0, 1
%0 = scf.if %c0 {
...
} else {
%1 = scf.if %c1 {
...
} else {
...
}
}
jiahanxie353
force-pushed
the
index-switch-to-if
branch
from
70e223c
to
fe89041
Compare
|
Thanks, refined the description and code based on your review! |
cgyurgyik
reviewed
Nov 14, 2024
jiahanxie353
force-pushed
the
index-switch-to-if
branch
from
0da30e4
to
dccf153
Compare
|
hi @rachitnigam , does this patch look good to you now? |
…ith invoking switchOp getCases many times by initialize a variable
jiahanxie353
force-pushed
the
index-switch-to-if
branch
from
dccf153
to
473d329
Compare
|
This patch failed nightly valgrind regressions: https://github.com/llvm/circt/actions/runs/12030131054/job/33536896034#step:6:5229 |
seldridge
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts commit d379a35. This patch failed valgrind nightly regressions. I'm blamelessly reverting this to keep nightly clean.
seldridge
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts commit d379a35. This patch failed valgrind nightly regressions. I'm blamelessly reverting this to keep nightly clean.
|
Blamelessly reverted in b987492 to keep nightly clean. |
Thanks for catching it @seldridge . Let me try to fix it. Do you know how to run FAILED: tools/circt/test/CMakeFiles/check-circt /__w/circt/circt/build/tools/circt/test/CMakeFiles/check-circt
cd /__w/circt/circt/build/tools/circt/test && /usr/bin/python3.9 /__w/circt/circt/build/./bin/llvm-lit -v --show-unsupported --vg /__w/circt/circt/build/tools/circt/testbut I can't find all those directories locally. For example, there's no |
|
It may just work if you take that test and run in through That then runs every test under |
I see, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transform is meant for dialects that inherently does not have a
switchcontrol statement (like Calyx)