-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HandshakeToDC] Getting some working tests #7858
base: main
Are you sure you want to change the base?
Conversation
teqdruid
commented
Nov 20, 2024
- Adding port name propagation to HandshakeToDC
- Configurable port names for clock and reset
- Add ESIPrimitives.sv to the list of SV files
- Adding test runs for a few integration tests which look like they should work, but then disabling running if they don't.
fe4b989
to
b37b8e6
Compare
- Adding port name propagation to HandshakeToDC - Configurable port names for clock and reset - Add ESIPrimitives.sv to the list of SV files - Adding test runs for a few integration tests which look like they should work, but then disabling running if they don't.
b37b8e6
to
ee72a42
Compare
Many of the failing tests are due to a compile error:
I am running that pass and I think it's nested correctly... am I not running it correctly? |
Looks correct to me. How does the IR look prior to |
@mortbopet Let's merge this with the TODOs in the tests to fix the fork issue. Dunno when I'll get around to fixing that bug, but I want to merge all my outstanding work before Thanksgiving weekend and I forget everything. |