Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HandshakeToDC] Getting some working tests #7858

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

teqdruid
Copy link
Contributor

  • Adding port name propagation to HandshakeToDC
  • Configurable port names for clock and reset
  • Add ESIPrimitives.sv to the list of SV files
  • Adding test runs for a few integration tests which look like they should work, but then disabling running if they don't.

- Adding port name propagation to HandshakeToDC
- Configurable port names for clock and reset
- Add ESIPrimitives.sv to the list of SV files
- Adding test runs for a few integration tests which look like they
should work, but then disabling running if they don't.
@teqdruid
Copy link
Contributor Author

Many of the failing tests are due to a compile error:

/home/jodemme/circt/integration_test/Dialect/Handshake/multiple_loops/multiple_loops.mlir:16:1: error: 'dc.fork' op DCToHW: value %3:3 = "dc.fork"(%arg1) : (!dc.token) -> (!dc.token, !dc.token, !dc.token) is unused.
func.func @top(%N: i64) -> (i64, i64) {
^
/home/jodemme/circt/integration_test/Dialect/Handshake/multiple_loops/multiple_loops.mlir:16:1: note: see current operation: %3:3 = "dc.fork"(%arg1) : (!dc.token) -> (!dc.token, !dc.token, !dc.token)
/home/jodemme/circt/integration_test/Dialect/Handshake/multiple_loops/multiple_loops.mlir:0:0: error: 'builtin.module' op DCToHW: failed to verify that all values are used exactly once. Remember to run the fork/sink materialization pass before HW lowering.

I am running that pass and I think it's nested correctly... am I not running it correctly?

@mortbopet
Copy link
Contributor

I am running that pass and I think it's nested correctly... am I not running it correctly?

Looks correct to me. How does the IR look prior to DCToHW?

@teqdruid
Copy link
Contributor Author

@mortbopet Let's merge this with the TODOs in the tests to fix the fork issue. Dunno when I'll get around to fixing that bug, but I want to merge all my outstanding work before Thanksgiving weekend and I forget everything.

@teqdruid teqdruid marked this pull request as ready for review November 27, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants