Lebesgue differentiation theorem and applications #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
force-pushed
the
leb_diff_thm
branch
from
65c87be to
1bcb8f2
Compare
affeldt-aist
force-pushed
the
leb_diff_thm
branch
2 times, most recently
from
3d0f96d to
429e835
Compare
CohenCyril
reviewed
Dec 7, 2023
affeldt-aist
force-pushed
the
leb_diff_thm
branch
from
429e835 to
e359088
Compare
3 tasks
affeldt-aist
force-pushed
the
leb_diff_thm
branch
3 times, most recently
from
63cb876 to
b499b5c
Compare
affeldt-aist
force-pushed
the
leb_diff_thm
branch
2 times, most recently
from
ad48d68 to
c09396a
Compare
affeldt-aist
force-pushed
the
leb_diff_thm
branch
from
c09396a to
4349835
Compare
|
i have not yet done the changelog and I have not yet moved the lemmas to the right files but this might wait a first round of review I think |
zstone1
reviewed
Mar 3, 2024
There was a problem hiding this comment.
Looks much improved. the FTC statements look much better with generic Interval stuff. There's definitely some stuff to shuffle around to other files, but seems like you are on top of that.
My main concern is a few lemmas that can be rephrased to be local statements. It should clean things up to remove the {in E, continuous f} which can be unintuitive.
affeldt-aist
force-pushed
the
leb_diff_thm
branch
3 times, most recently
from
5d2b410 to
8382a6c
Compare
Co-authored-by: zstone1 <[email protected]>
affeldt-aist
force-pushed
the
leb_diff_thm
branch
from
8382a6c to
68d61c3
Compare
zstone1
reviewed
Mar 14, 2024
zstone1
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is track D of issue #965
This is based of PR #995(merged)Based on PR #1121(merged)Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.