Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolate the theory of lime_sup #1121

Merged
merged 4 commits into from
Jan 7, 2024
Merged

Conversation

affeldt-aist
Copy link
Member

Motivation for this change

from the PR #1065 on the Lebesgue differentiation theorem

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added enhancement ✨ This issue/PR is about adding new features enhancing the library TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. labels Dec 21, 2023
@affeldt-aist affeldt-aist added this to the 0.6.7 milestone Dec 21, 2023
@affeldt-aist affeldt-aist requested a review from zstone1 December 21, 2023 05:35
@affeldt-aist
Copy link
Member Author

What about adding these (loosely related) lemmas https://github.com/zstone1/analysis/blob/total_variation/theories/realfun.v#L1323-L1352
to this PR?

@affeldt-aist
Copy link
Member Author

Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repeated proofs about swapping between sequential and filter convergence are annoying, but tough to fix without a little extra machinery.

The interesting question is about generalizing this to consider the lim_sup of a function "at a filter". If it's an easy generalization, we should do it now. If it's tough, then we may have to revisit the material when we do sequence limsups.

Section cvgr_fun_cvg_seq.
Context {R : realType}.

Lemma cvg_at_rightP (f : R -> R) (p l : R) :
Copy link
Contributor

@zstone1 zstone1 Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a textbook all four of these proofs would be three liners:

  1. In first countable spaces, filter convergence <-> sequence convergence
  2. The lower (upper) limit topology (AKA sogenfrey line) is first countable
  3. All sequences in the lower (upper) limit topology that converge, do so from the left (right).

The proof you have is fine, I'm not complaining about it. I am complaining that some missing classical machinery is making these proofs longer than necessary. A problem for another day, I guess.

theories/realfun.v Show resolved Hide resolved
theories/realfun.v Outdated Show resolved Hide resolved
theories/realfun.v Outdated Show resolved Hide resolved
theories/realfun.v Outdated Show resolved Hide resolved
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One meaningful question about the right sided limit. And then, if you're up for it, generalizing more of the lemmas to work for limf

theories/realfun.v Show resolved Hide resolved
theories/realfun.v Show resolved Hide resolved
@affeldt-aist affeldt-aist merged commit 8196991 into math-comp:master Jan 7, 2024
26 of 30 checks passed
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Jan 9, 2024
* isolate the theory of lime_sup

- generic def of limsup

---------

Co-authored-by: Zachary Stone <[email protected]>
proux01 pushed a commit that referenced this pull request Jan 9, 2024
* isolate the theory of lime_sup

- generic def of limsup

---------

Co-authored-by: Zachary Stone <[email protected]>
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants