Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal changes to documentation to test coq2html #1108

Merged
merged 6 commits into from
Jan 8, 2024

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Nov 24, 2023

Motivation for this change

The goal of this PR is to test a fork of coq2html to document MathComp-Analysis
using mardown.

fixes #1114

fixes #1071

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added the experiment 🧪 This issue/PR is very experimental label Dec 3, 2023
@affeldt-aist affeldt-aist force-pushed the coq2html_format branch 5 times, most recently from d340090 to 2fc1a66 Compare December 8, 2023 06:44
@affeldt-aist affeldt-aist added the documentation 📝 This issue/PR is about documentation of the library / repository label Dec 8, 2023
@affeldt-aist affeldt-aist added this to the 0.6.7 milestone Dec 8, 2023
@affeldt-aist affeldt-aist marked this pull request as ready for review December 8, 2023 08:08
@affeldt-aist affeldt-aist mentioned this pull request Jan 2, 2024
3 tasks
@affeldt-aist affeldt-aist requested a review from proux01 January 5, 2024 08:00
Copy link
Collaborator

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@affeldt-aist @yoshihiro503 The doc generated at https://yoshihiro503.github.io/coq2html/ looks really great and this seems a worthwile replacement of coqdoc, here are just a few minor comments by looking at it:

Overall, the only features I can see missing from coqdoc (but we don't use them in mathcomp) are:

  • the table of content generated from the first title of each file, following the order of the _CoqProject
  • the ability to easily link to constants in the comments (by just surrounding them with [ and ]

classical/boolp.v Outdated Show resolved Hide resolved
classical/classical_sets.v Outdated Show resolved Hide resolved
@affeldt-aist
Copy link
Member Author

Here is the result of the rebase:

@affeldt-aist affeldt-aist added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jan 8, 2024
@@ -7,18 +7,18 @@

From mathcomp Require Import all_ssreflect.

(******************************************************************************)
(* Classical Logic *)
(***md*************************************************************************)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, are th three stars before md mandatory? why not just two? (coqdoc syntax is (** IIRC so not sure a third star is needed)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's arbitrary. No strong reason I think.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we don't really care because there are stars all along the line. But in case we wouldn't use block comments, with stars all around, but just start (* and closing *) syntax, the less stars the better I'd say.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll clarify this on Friday.

@affeldt-aist affeldt-aist merged commit 9d58aca into math-comp:master Jan 8, 2024
26 of 30 checks passed
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Jan 9, 2024
proux01 pushed a commit that referenced this pull request Jan 9, 2024
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📝 This issue/PR is about documentation of the library / repository experiment 🧪 This issue/PR is very experimental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lacking a Proof command coqdoc formatting command
2 participants