-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal changes to documentation to test coq2html #1108
Conversation
d340090
to
2fc1a66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@affeldt-aist @yoshihiro503 The doc generated at https://yoshihiro503.github.io/coq2html/ looks really great and this seems a worthwile replacement of coqdoc, here are just a few minor comments by looking at it:
- very minor: HTML title of that page: "Module $NAME"
- minor but probably easy to fix: missing purple keywords
- Set Implicit Arguments.
- Unset Strict Implicit
- Unset Printing Implicit Defensive
- Number Notation
- Declare Scope
- Delimit Scope
- Bind Scope
- Local
- very minor: some links to stdlib notations are partly broken (for instance https://coq.inria.fr/doc/V8.18.0/stdlib/Coq.Init.Specif.html#::type_scope:'{'_x_':'_x_'|'_x_'&'_x_'}' or https://coq.inria.fr/doc/V8.18.0/stdlib/Coq.ssr.ssrfun.html#::fun_scope:x_'=1'_x )
- very minor: some links to mathcomp seem broken: https://math-comp.github.io/htmldoc/mathcomp.algebra.ssralg.html#GRing.Zmodule.Exports.zmodType
(looks like it's not a coq2html bug but the fact that doc of Analysis master (still on MC1) should link to the doc of MC1 not MC master (MC2)) - minor: some internal links seem broken: https://yoshihiro503.github.io/coq2html/mathcomp.classical.mathcomp_extra.html#P:4 works great but https://yoshihiro503.github.io/coq2html/mathcomp.classical.mathcomp_extra.html#T:2 doesn't
- serious: links to section variables can be broken, for instance https://yoshihiro503.github.io/coq2html/mathcomp.analysis.measure.html#classes.G
- serious: some links to HB defined types are broken, for instance https://yoshihiro503.github.io/coq2html/mathcomp.analysis.measure.html#ringOfSetsType
- not sure why
HB.mixin
and someHB.instance
get displayed in red but not allHB.structure
(I would either display nothing in red or all of the commands in https://github.com/math-comp/hierarchy-builder/blob/master/structures.v with some link to that file in addition to the color - very minor: in
#[short(type=semiRingOfSetsType)]
, an extra spurious space is introduced aftershort
Overall, the only features I can see missing from coqdoc (but we don't use them in mathcomp) are:
- the table of content generated from the first title of each file, following the order of the
_CoqProject
- the ability to easily link to constants in the comments (by just surrounding them with
[
and]
86d939e
to
ed17518
Compare
Here is the result of the rebase:
|
@@ -7,18 +7,18 @@ | |||
|
|||
From mathcomp Require Import all_ssreflect. | |||
|
|||
(******************************************************************************) | |||
(* Classical Logic *) | |||
(***md*************************************************************************) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, are th three stars before md
mandatory? why not just two? (coqdoc syntax is (**
IIRC so not sure a third star is needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's arbitrary. No strong reason I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we don't really care because there are stars all along the line. But in case we wouldn't use block comments, with stars all around, but just start (*
and closing *)
syntax, the less stars the better I'd say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll clarify this on Friday.
* test a few files
Motivation for this change
The goal of this PR is to test a fork of coq2html to document MathComp-Analysis
using mardown.
fixes #1114
fixes #1071
Things done/to do
CHANGELOG_UNRELEASED.md
Compatibility with MathComp 2.0
TODO: HB port
to make sure someone ports this PR tothe
hierarchy-builder
branch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.