Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wochoice #1173

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Wochoice #1173

merged 5 commits into from
Mar 28, 2024

Conversation

Tragicus
Copy link
Collaborator

Motivation for this change

Adds a proof of Zorn's lemma, Hausdorff maximal principle and the well ordering principle.
Contains a patch of contra that we may want to extract.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist
Copy link
Member

Contains a patch of contra that we may want to extract.

Do you mean that it ought to be a different PR? (That may help the review process.)

@Tragicus
Copy link
Collaborator Author

Tragicus commented Mar 5, 2024

I would not go so far as "ought to", the fix is quite trivial, but if you would prefer a different PR, I can do it.

@affeldt-aist
Copy link
Member

the fix is quite trivial

Ok. Since there is a number of definitions that are added to contra.v and many canonicals, it didn't look trivial to me ^_^.

if you would prefer a different PR, I can do it.

I think that it is better (different concerns, two commits are maybe better also for the git log).

@CohenCyril
Copy link
Member

@Tragicus could you rephrase your commit message so as to make

Co-Authored-By: Georges Gonthier <[email protected]>

a single line separated from the title by a white line, and verbatim (otherwise github does not pick it up)

proux01 pushed a commit to Tragicus/analysis that referenced this pull request Mar 28, 2024
@proux01 proux01 merged commit 8a3a13a into math-comp:master Mar 28, 2024
24 checks passed
@proux01
Copy link
Collaborator

proux01 commented Mar 28, 2024

Argh, I accidentally merged this instead of #1183 and I don't have push right on master to revert that, could someone do it, maybe @CohenCyril ?

@proux01
Copy link
Collaborator

proux01 commented Mar 28, 2024

Done with @affeldt-aist
@Tragicus could you please reopen the PR, sorry again.

affeldt-aist pushed a commit that referenced this pull request Mar 28, 2024
@Tragicus
Copy link
Collaborator Author

Can I also rebase and clean up now?

@proux01
Copy link
Collaborator

proux01 commented Mar 28, 2024

Sure, thanks

@Tragicus
Copy link
Collaborator Author

Reopened at #1198

@proux01 proux01 mentioned this pull request Mar 28, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants