-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wochoice #1198
Wochoice #1198
Conversation
FTR, this is a reopening of #1173 following my unwanted merge there. |
I think that we'd like to use File "./theories/derive.v", line 5, characters 0-79:
Error: Universe inconsistency. Cannot enforce
mathcomp.field.algebraics_fundamentals.48897 <= Coq.ssr.ssrfun.107 because
Coq.ssr.ssrfun.107 < Num.ArchimedeanField.type.u0
<= mathcomp.field.algebraics_fundamentals.48897. I vaguely remember that we already ran into that kind of problem. What can I do? |
@proux01 @CohenCyril any quick hint? (We are in the process of deriving our Zorn's lemmas from Georges'.) |
The first difficulty is to understand where the universe constraint(s) comes from. The best way I know to find out is to use |
@proux01 Thank you for the pointer! (I didn't know.) I was able to avoid the universe inconsistency without really understanding it by just removing useless As far as the PR is concerned, I just tried to derive existing Zorn's lemmas using @ggonthier 's to avoid duplicates. There is certainly more to do since some definitions in |
This topic was discussed during a mathcomp-analysis-dev meeting: https://github.com/math-comp/analysis/wiki/2024-04-16-Meeting The conclusion was to integrate this PR, keeping bool/Prop duplicates, favoring Prop in general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR newly introduces difficult standard lemmas that we have been able to use to revise and shorten classical_sets.v
. Sure, it introduces definitions that are likely to move to MathComp and that are bool-variants of existing definitions in Prop but we won't clear that up in the very near future so we'd better merge and come back to it imo.
@ggonthier ok with merging? |
Co-authored-by: Georges Gonthier <[email protected]>
@Tragicus had a look (including the changelog) so I might merge today to release. |
- CI fix to please Coq 8.16 - change copyright after consulting georges - changelog and doc
(reopening of #1173 )
Adds a proof of Zorn's lemma, Hausdorff maximal principle and the well ordering principle.
Motivation for this change
Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Reminder to reviewers