Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility lemmas in Rstruct #1235

Merged
merged 5 commits into from
May 31, 2024
Merged

Improve compatibility lemmas in Rstruct #1235

merged 5 commits into from
May 31, 2024

Conversation

t6s
Copy link
Member

@t6s t6s commented May 30, 2024 •
edited
Loading

Motivation for this change

  • Lemmas RinvE and RdivE are generalized:
    originally these lemmas took proofs that the argument to be inverted is not zero.
    This PR removes it and unconditionally equates the corresponding operations for stdlib reals and mca reals.

  • Lemma IZposRE is added:
    Like INRE, this lemma is meant to be used for translating natural number literals in stdlib reals to mca literals.
    Its intermediate step Pos_to_natE is added too.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@t6s t6s requested a review from affeldt-aist May 30, 2024 05:34
affeldt-aist
affeldt-aist approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this simplification brought by recent versions of the Coq standard library.

@affeldt-aist affeldt-aist merged commit dd40c51 into math-comp:master May 31, 2024
16 checks passed
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Jun 20, 2024
@t6s @affeldt-aist @IshiguroYoshihiro
Improve compatibility lemmas in Rstruct (math-comp#1235)
99ca0e0 
* strengthen RinvE and RdivE; add Pos_to_natE and IZposRE

---------

Co-authored-by: Reynald Affeldt <[email protected]>
@affeldt-aist affeldt-aist mentioned this pull request Jul 19, 2024
Open
@t6s t6s deleted the RinvE branch November 15, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@affeldt-aist affeldt-aist affeldt-aist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t6s @affeldt-aist