Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing discrete topologies #1323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Sep 20, 2024

Adding discrete topologies, uniformities, and metrics to the hierarchy. Cleans up a bunch of pre-HB issues, and now we can use bool directly instead of through a bunch of aliases. We can now just write cantor_space = prod_topology (fun=> bool) and Uniform.on cantor_space. Pretty nice!

However, I encountered a lot of weird HB errors. I put in tickets math-comp/hierarchy-builder#447 and math-comp/hierarchy-builder#446

Furthermore, I could only get this to compile with a call to HB.saturate. This is fine, except that it the commands takes several minutes to run. And is broken on master with error

Error: The elpi tactic/command HB.saturate failed without giving a specific
error message. Please report this inconvenience to the authors of the
program.

I am skeptical if I get a build that works on both master and the current release

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@zstone1 zstone1 requested a review from CohenCyril September 25, 2024 00:14
@zstone1 zstone1 added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Sep 25, 2024
@CohenCyril
Copy link
Member

@zstone1 HB.saturate is a perfectly valid command to call. Hopefully in the future we make sure HB handles this automatically.

@zstone1
Copy link
Contributor Author

zstone1 commented Oct 3, 2024

The problem I'm having is that it takes 3 minutes to run that one command. Since I know what structure i want it to saturate for, is there anyway for me to improve its performance?

@CohenCyril
Copy link
Member

The problem I'm having is that it takes 3 minutes to run that one command. Since I know what structure i want it to saturate for, is there anyway for me to improve its performance?

Yes, but in the next HB release. math-comp/hierarchy-builder#414

@zstone1 zstone1 marked this pull request as ready for review October 3, 2024 16:05
@zstone1
Copy link
Contributor Author

zstone1 commented Oct 29, 2024

All the reshuffling of topology_theory seems to have unblocked this. Although the underlying issue is probably still around, this is now ready for a proper review

@zstone1 zstone1 requested a review from affeldt-aist October 29, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants