Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add continuous_within_itvcyP/ycP #1376

Conversation

IshiguroYoshihiro
Copy link
Contributor

Motivation for this change

add unbound interval version of continuous_within_itvP,
which is used in my other work.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist
Copy link
Member

The last commits factorize out redundant code snippets. @zstone1 do you think we should make more efforts to simplify the proofs?

@zstone1
Copy link
Contributor

zstone1 commented Nov 14, 2024

With a software engineering perspective, it's annoying that the proofs for left-convergence and right-convergence are basically copy-pasted (modulo a few opprKs). But things are now pretty short, so I think this is acceptable

@affeldt-aist affeldt-aist force-pushed the continuous_within_itvP20241030 branch from 8b3179b to 7c496f4 Compare December 2, 2024 03:46
@affeldt-aist affeldt-aist merged commit 61b7572 into math-comp:master Dec 2, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants