Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tentative formalization of Vitali's lemma #973

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jul 10, 2023

Motivation for this change

track C of issue #965

(statements are being tested in other branches, to clean as soon as it stabilized)

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great. I've posted a couple questions here, but nothing deep. And I haven't looked thoroughly at the vitali lemma proof itself. But the structure seems fairly reasonable.

theories/lebesgue_measure.v Outdated Show resolved Hide resolved
theories/lebesgue_measure.v Outdated Show resolved Hide resolved
theories/lebesgue_measure.v Outdated Show resolved Hide resolved
theories/lebesgue_measure.v Outdated Show resolved Hide resolved
theories/lebesgue_measure.v Outdated Show resolved Hide resolved
theories/lebesgue_measure.v Outdated Show resolved Hide resolved
theories/lebesgue_measure.v Outdated Show resolved Hide resolved
@affeldt-aist affeldt-aist force-pushed the vitali_lemma branch 3 times, most recently from 697cb52 to 6094827 Compare July 17, 2023 07:59
@affeldt-aist affeldt-aist marked this pull request as ready for review July 23, 2023 21:21
@affeldt-aist affeldt-aist added this to the 0.6.4 milestone Jul 23, 2023
@affeldt-aist affeldt-aist added enhancement ✨ This issue/PR is about adding new features enhancing the library TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. labels Jul 23, 2023
@affeldt-aist affeldt-aist modified the milestones: 0.6.4, 0.6.5 Aug 5, 2023
@affeldt-aist affeldt-aist mentioned this pull request Aug 8, 2023
3 tasks
@affeldt-aist affeldt-aist modified the milestones: 0.6.5, 0.6.6 Sep 28, 2023
@affeldt-aist affeldt-aist force-pushed the vitali_lemma branch 3 times, most recently from 450b010 to 33f74fc Compare October 2, 2023 15:30
@affeldt-aist affeldt-aist marked this pull request as draft October 16, 2023 10:04
@affeldt-aist affeldt-aist marked this pull request as ready for review October 25, 2023 13:05
@affeldt-aist
Copy link
Member Author

I still have to write the changelog and double-check the documentation,
but, modulo these two points, I'd like to have some light-review asap and
an approval to merge: if there are minor problems we will still have an
opportunity to fix them soon since at least two forthcoming PRs depend
on this one (and it is painful to systematically rebased PRs on PR for me...).

@affeldt-aist
Copy link
Member Author

The main change with the original version is that we have introduced
a predicate is_ball so that family of balls can be represented by the
datatype I -> set R. That hasn't changed the structure of proofs, but
thanks to that we now have a function scall_ball from set to set
and we use closure to denote closed balls, which is closer to what
paper proofs look like.

@affeldt-aist affeldt-aist merged commit 94d93cc into math-comp:master Nov 9, 2023
18 checks passed
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Nov 14, 2023
* tentative formalization of Vitali's lemmas
proux01 pushed a commit that referenced this pull request Nov 15, 2023
* tentative formalization of Vitali's lemmas
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants