Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor generalizations, additions, fixes #974

Merged
merged 1 commit into from
Jul 16, 2023
Merged

minor generalizations, additions, fixes #974

merged 1 commit into from
Jul 16, 2023

Conversation

affeldt-aist
Copy link
Member

This PR deals with a few trivialities to ease forthcoming reviews.

Motivation for this change
Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added enhancement ✨ This issue/PR is about adding new features enhancing the library renaming/refactoring 🔧 This is about a renaming or refactoring in the library TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. labels Jul 12, 2023
@affeldt-aist affeldt-aist added this to the 0.6.4 milestone Jul 12, 2023
zstone1
zstone1 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these generalizations and renamings. Just a heads up it will generate minor merge conflicts with my PRs, but I'll fix on my end once this is in.

@affeldt-aist affeldt-aist merged commit 7622cc7 into math-comp:master Jul 16, 2023
This was referenced Jul 17, 2023
Merged
Merged
affeldt-aist added a commit to affeldt-aist/analysis that referenced this pull request Jul 20, 2023
@affeldt-aist
minor generalizations, additions, fixes (math-comp#974)
6182760 
- fixes math-comp#938
proux01 pushed a commit that referenced this pull request Jul 21, 2023
@affeldt-aist @proux01
minor generalizations, additions, fixes (#974)
b513e81 
- fixes #938
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jul 21, 2023
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Sep 7, 2023
@affeldt-aist @IshiguroYoshihiro
minor generalizations, additions, fixes (math-comp#974)
d5e62e8 
- fixes math-comp#938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zstone1 zstone1 zstone1 approved these changes

Assignees
No one assigned
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Projects
None yet
Milestone
0.6.4
Development

Successfully merging this pull request may close these issues.

naming of integralM
3 participants
@affeldt-aist @zstone1 @proux01