-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element-R: Emit CryptoEvent.UserTrustStatusChanged
when user identity is updated
#3716
Conversation
This now happens as a side-effect of importing the keys.
CryptoEvent.UserTrustStatusChanged
when user identity is updatedCryptoEvent.UserTrustStatusChanged
when user identity is updated
This is currently awaiting a release of Basically, once I call What seems to be happening is as follows:
So in short, we have a reference cycle which stops the store being cleaned up. |
This is fixed by matrix-org/matrix-rust-sdk-crypto-wasm#31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as far as I understand it, which is not a great deal.
I suspect the test failure was flakiness, re-adding to merge queue. For the record, the failure was:
|
If it merges, we should add a flaky test issue, similar but not identical to element-hq/element-web#25625 |
Fixes https://github.com/vector-im/crypto-internal/issues/148
This change is marked as an internal change (Task), so will not be included in the changelog.