🐛 Add hack/tools to bed linted and fix errors in deploy-cli #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
|
Can you also make it part of linting targets, so it does not get broken again? |
Rozzii
reviewed
Dec 13, 2024
Rozzii
previously requested changes
Dec 13, 2024
mquhuy
force-pushed
the
mquhuy/fix-deploy-cli
branch
from
4ba5f52 to
f6bf2bd
Compare
metal3-io-bot
added
size/M
lentzi90
reviewed
Dec 13, 2024
metal3-io-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
tuminoid
reviewed
Dec 16, 2024
|
/retitle 🐛 Add hack/tools to bed linted and fix errors in deploy-cli |
metal3-io-bot
changed the title
mquhuy
force-pushed
the
mquhuy/fix-deploy-cli
branch
from
f6bf2bd to
cf47f48
Compare
This commit fixes errors found by osv-scanner in deploy-cli [1] It also adds `hack/tools` package as a linting target, so that any failure due to dependencies changes will get detected in the future. [1] metal3-io#2121 Signed-off-by: Huy Mai <[email protected]>
mquhuy
force-pushed
the
mquhuy/fix-deploy-cli
branch
from
cf47f48 to
25f0c32
Compare
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pr fixes errors found by osv-scanner in deploy-cli.
It also adds
hack/toolspackage as a linting target, so thatany failure due to dependencies changes will get detected in the future.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2121