cache installed deps on CI #4796
Open
+35
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoftly
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
|
Is this any faster than letting pnpm install directly? I know for the main repo I support I abandoned dependency caching because it's faster to download and install the tarballs than the registry (though that is probably impacted by having a within-datacenter mirror). |
|
I'm sorry for omitting the description block ... I didn't realize that this would open outside of my repo. It's obviously not ready for review yet. @dmichon-msft the purpose of this PR is not for efficiency - it's for creating a documented reference for others to see. There was no clear place where I could conclusively find the best way to cache deps for rush, so I figured why not put it in the most authoritative place - the source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
How it was tested
Impacted documentation