Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache installed deps on CI #4796

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+35 −23
Open

cache installed deps on CI #4796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e0a2040
cache installed deps on CI
microsoftly Jun 19, 2024
9e084bf
correct hash?
microsoftly Jun 19, 2024
a8c3b41
add comment + trigger a new CI job that will validate whether or not …
microsoftly Jun 19, 2024
f16db62
specify comon for location of files to hash?
microsoftly Jun 19, 2024
c1c3720
try to cache like this?
microsoftly Jun 19, 2024
a2e8fe2
try this now
microsoftly Jun 19, 2024
42660cb
try this jawn
microsoftly Jun 19, 2024
c9cc0c8
more tweaking
microsoftly Jun 19, 2024
d9820bb
make a noop ∆ to trigger a rerun
microsoftly Jun 19, 2024
69446ea
try double glob
microsoftly Jun 19, 2024
1848dc2
check against any pnpm locks
microsoftly Jun 19, 2024
7a35765
noop change to trigger reexecution
microsoftly Jun 19, 2024
9904def
test again
microsoftly Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 34 additions & 22 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ jobs:
run: node common/scripts/install-run-rush.js change --verify
working-directory: repo-a

- name: Cache Rush Installed Dependencies
id: cache-deps
uses: actions/cache@v3
with:
path: |
repo-a/common/temp/node_modules
repo-a/common/temp/**/node_modules
repo-a/common/pnpm-store

# If lock files have changed, then we should reasonably assume that a new install is needed
key: ${{ matrix.NodeVersionDisplayName }}+(${{ matrix.OS }})-${{ hashFiles('repo-a/common/**/pnpm-lock.yaml') }}

- name: Rush Install
run: node common/scripts/install-run-rush.js install
working-directory: repo-a
Expand All @@ -67,30 +79,30 @@ jobs:
# run: /usr/bin/Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
# working-directory: repo-a

- name: Rush retest (install-run-rush)
run: node common/scripts/install-run-rush.js retest --verbose --production
working-directory: repo-a
# - name: Rush retest (install-run-rush)
# run: node common/scripts/install-run-rush.js retest --verbose --production
# working-directory: repo-a

- name: Ensure repo README is up-to-date
run: node repo-scripts/repo-toolbox/lib/start.js readme --verify
working-directory: repo-a
# - name: Ensure repo README is up-to-date
# run: node repo-scripts/repo-toolbox/lib/start.js readme --verify
# working-directory: repo-a

- name: Clone another copy of the repo to test the build cache
uses: actions/checkout@v3
with:
fetch-depth: 1
path: repo-b
# - name: Clone another copy of the repo to test the build cache
# uses: actions/checkout@v3
# with:
# fetch-depth: 1
# path: repo-b

- name: Git config user
run: |
git config --local user.name "Rushbot"
git config --local user.email "[email protected]"
working-directory: repo-b
# - name: Git config user
# run: |
# git config --local user.name "Rushbot"
# git config --local user.email "[email protected]"
# working-directory: repo-b

- name: Rush update (rush-lib)
run: node ${{ github.workspace }}/repo-a/apps/rush/lib/start-dev.js update
working-directory: repo-b
# - name: Rush update (rush-lib)
# run: node ${{ github.workspace }}/repo-a/apps/rush/lib/start-dev.js update
# working-directory: repo-b

- name: Rush test (rush-lib)
run: node ${{ github.workspace }}/repo-a/apps/rush/lib/start-dev.js test --verbose --production --timeline
working-directory: repo-b
# - name: Rush test (rush-lib)
# run: node ${{ github.workspace }}/repo-a/apps/rush/lib/start-dev.js test --verbose --production --timeline
# working-directory: repo-b
2 changes: 1 addition & 1 deletion common/config/subspaces/build-tests-subspace/repo-state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
{
"pnpmShrinkwrapHash": "c040a0d59aada7e1f9bdf0916df7079547de3a85",
"preferredVersionsHash": "ce857ea0536b894ec8f346aaea08cfd85a5af648",
"packageJsonInjectedDependenciesHash": "25b153582664854d3f0080a8d4fb2ce9dd409aed"
"packageJsonInjectedDependenciesHash": "faf9f64843602dd4f48cdea4308e7b00fe222387"
}
Loading