Enable logging to a file #1856
Enable logging to a file #1856
Conversation
azarovh
requested review from
erubboli,
ImplOfAnImpl and
OBorce
as code owners
|
I should probably mention why I refactored the functions inside runner.rs |
| @@ -48,6 +49,7 @@ use crate::{ | |||
| }; | |||
|
|
|||
| const LOCK_FILE_NAME: &str = ".lock"; | |||
| const LOG_FILE_NAME: &str = "mintlayer.log"; | |||
There was a problem hiding this comment.
Perhaps the name should be based on the executable?
| /// Log to a file | ||
| #[clap(long, action = clap::ArgAction::Set)] | ||
| #[arg(hide = true)] | ||
| pub log_to_file: Option<bool>, |
There was a problem hiding this comment.
Should we hide it?
(If not, the description should be more detailed, mentioning that the default value depends on the application and where the logs will be located).
| AppendCount::new(2), // total 3 file | ||
| ContentLimit::Bytes(100_000_000), // 100MB each |
There was a problem hiding this comment.
100 mb seems too much for one file.
IMO we should measure roughly how much logs the node produces in a day and make it the max size. And the number of files can be e.g. 7 (or 10, or 14).
For GUI logging to a file is enabled by default. For other apps it's off with an option to enable it explicitly.