Enable logging to a file

Cargo.toml

@@ -162,6 +162,7 @@ enum-iterator = "2.0"
 enumflags2 = "0.7"
 expect-test = "1.3"
 fallible-iterator = "0.3"
+file-rotate = "0.7"
 fix-hidden-lifetime-bug = "0.2"
 fixed-hash = "0.8"
 flate2 = "1.0"

node-daemon/src/main.rs

@@ -15,9 +15,7 @@
 
 pub async fn run() -> anyhow::Result<()> {
     let opts = node_lib::Options::from_args(std::env::args_os());
-    logging::init_logging();
-    logging::log::info!("Command line options: {opts:?}");
-    let setup_result = node_lib::setup(opts, false).await?;
+    let setup_result = node_lib::setup(opts).await?;
     match setup_result {
         node_lib::NodeSetupResult::Node(node) => {
             node.main().await;

node-gui/backend/src/lib.rs

@@ -120,30 +120,37 @@ pub async fn node_initialize(
         );
     }
 
-    let mut opts = node_lib::Options::from_args(std::env::args_os());
-    opts.command = match network {
-        InitNetwork::Mainnet => Some(Command::Mainnet(RunOptions::default())),
-        InitNetwork::Testnet => Some(Command::Testnet(RunOptions::default())),
+    let opts = {
+        let mut opts = node_lib::Options::from_args(std::env::args_os());
+        let run_opts = {
+            // For the GUI, we configure different defaults, such as disabling RPC server binding
+            // and enabling logging to a file.
+            let mut run_opts =
+                opts.command.map_or(RunOptions::default(), |c| c.run_options().clone());
+            run_opts.rpc_enabled = Some(run_opts.rpc_enabled.unwrap_or(false));
+            run_opts.log_to_file = Some(run_opts.log_to_file.unwrap_or(true));
+            run_opts
+        };
+        opts.command = match network {
+            InitNetwork::Mainnet => Some(Command::Mainnet(run_opts)),
+            InitNetwork::Testnet => Some(Command::Testnet(run_opts)),
+        };
+        opts
     };
 
-    logging::init_logging();
-    logging::log::info!("Command line options: {opts:?}");
-
     let (request_tx, request_rx) = unbounded_channel();
     let (event_tx, event_rx) = unbounded_channel();
     let (low_priority_event_tx, low_priority_event_rx) = unbounded_channel();
     let (wallet_updated_tx, wallet_updated_rx) = unbounded_channel();
 
     let (chain_config, chain_info) = match mode {
         WalletMode::Hot => {
-            let setup_result = node_lib::setup(opts, true).await?;
+            let setup_result = node_lib::setup(opts).await?;
             let node = match setup_result {
                 node_lib::NodeSetupResult::Node(node) => node,
                 node_lib::NodeSetupResult::DataDirCleanedUp => {
                     // TODO: find more friendly way to report the message and shut down GUI
-                    anyhow::bail!(
-                "Data directory is now clean. Please restart the node without `--clean-data` flag"
-            );
+                    anyhow::bail!("Data directory is now clean. Please restart the node without `--clean-data` flag");
                 }
             };
 

node-lib/Cargo.toml

@@ -24,6 +24,7 @@ utils-networking = { path = "../utils/networking" }
 
 anyhow.workspace = true
 clap = { workspace = true, features = ["derive"] }
+file-rotate.workspace = true
 jsonrpsee = { workspace = true, features = ["macros"] }
 tokio = { workspace = true, default-features = false }
 serde = { workspace = true, features = ["derive"] }

node-lib/src/options.rs

@@ -66,6 +66,15 @@ pub enum Command {
     Regtest(Box<RegtestOptions>),
 }
 
+impl Command {
+    pub fn run_options(&self) -> &RunOptions {
+        match self {
+            Command::Mainnet(run_options) | Command::Testnet(run_options) => run_options,
+            Command::Regtest(regtest_options) => &regtest_options.run_options,
+        }
+    }
+}
+
 #[derive(Args, Clone, Debug)]
 pub struct RegtestOptions {
     #[clap(flatten)]
@@ -80,6 +89,11 @@ pub struct RunOptions {
     #[clap(long, short, action = clap::ArgAction::SetTrue)]
     pub clean_data: Option<bool>,
 
+    /// Log to a file
+    #[clap(long, action = clap::ArgAction::Set)]
+    #[arg(hide = true)]
+    pub log_to_file: Option<bool>,
+
     /// Minimum number of connected peers to enable block production.
     #[clap(long, value_name = "COUNT")]
     pub blockprod_min_peers_to_produce_blocks: Option<usize>,