Pr/spektrum accept 0x01or0x02 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'no first frame' error message to print in fewer than 80 characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Some combinations of Spectrum RC Transmitters bound to the satellite receiver on the VOXL2 Sentinel drone result in DSM packets with protocol byte 0x01. The current spektrum_rc driver will only accept packets with 0x02 protocol byte. The current system will reject DSM packets in this case and not print the protocol version as the string is too long for the character terminal.
Addresses VOXL2 forum issue: https://forum.modalai.com/topic/2703/voxl2-spektrum-receiver-error/
Solution
Changelog Entry
For release notes: Change spectrum_rc to accept protocol bytes 0x01 or 0x02 and shorten 'no first frame' error message to print in fewer than 80 characters
Alternatives
This avoids having to try alternative transmitter hardware
Test coverage
Ground test with DX7 transmitter shows expected behavior passing valid rc_input to the system. Input pauses and resumes as expected cycling power on the transmitter and VOXL2.