-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUMI-127 adding inference API #328
Conversation
@javiermtorres I added you as a reviewer because I saw the SDK integration test failed, but I had no issues testing locally with |
@aittalam I will include the SDK integration tests in the test target (maybe they're not already included). The issue is the split of JobCreate, so it is not found by the integration tests. Let me provide a branch that can be merged into yours to solve this issue. |
For reference, complementary job in progress: #333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aittalam !
I'd be happy to ship this and start using it if we can remove part of the dupe code create_inference and create_eval have 😄 Just cleaning up one corner at a time.
Includes SDK code, and mocked and integration tests. Co-authored-by: Javier Torres <[email protected]>
* Support Alembic in tests --------- Signed-off-by: Peter Wilson <[email protected]>
* Changed local development favoring docker-compose watch&sync instead of volume mounting to avoid .venv conflicts --------- Signed-off-by: Alejandro Gonzalez <[email protected]> Co-authored-by: Alejandro Gonzalez <[email protected]>
* Update README.md Signed-off-by: Nate Brake <[email protected]> * Update README.md Ooh good idea, thanks! Co-authored-by: Vicki Boykis <[email protected]> Signed-off-by: Nate Brake <[email protected]> --------- Signed-off-by: Nate Brake <[email protected]> Co-authored-by: Vicki Boykis <[email protected]>
Signed-off-by: Davide Eynard <[email protected]>
Ok all, here are my updates:
LMK if anything else should be done or if this is good to go |
LGTM after those few changes, thanks for all your patience on this! 🚀 |
Co-authored-by: Peter Wilson <[email protected]> Signed-off-by: Davide Eynard <[email protected]>
What's changing
Added support for inference in our API:
Updated inference job to support the new configuration:
InferenceJobConfig
pydantic class to validate input dictionaryHow to test it
make test
cd lumigator/python/mzai/jobs/inference; uv run --with pytest --with-requirements requirements.txt --isolated pytest
test_dataset_upload && test_inference_mistral
test_dataset_upload:
test_inference_mistral:
Additional notes for reviewers
I already...