Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve balances query #41

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Feat/improve balances query #41

merged 10 commits into from
Jun 6, 2024

Conversation

ratik
Copy link
Contributor

@ratik ratik commented Feb 22, 2024 •
edited by sotnikov-s
Loading

@ratik ratik force-pushed the feat/improve-balances-query branch from a1dcc8c to 7e91e9e Compare February 22, 2024 15:30
@ratik ratik force-pushed the feat/improve-balances-query branch from 7e91e9e to abbba7f Compare February 22, 2024 15:35
@ratik ratik mentioned this pull request Feb 25, 2024
Merged
@ratik
Copy link
Contributor Author

ratik commented Feb 25, 2024

Test run

@ratik ratik requested a review from pr0n00gler February 27, 2024 09:11
sotnikov-s
sotnikov-s requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to

  1. extend ICQ contract's interface to accept a list of denoms for balances query
  2. add integration tests covering multiple denoms and response with a zero value balance

will handle it myself later

@sotnikov-s sotnikov-s mentioned this pull request May 31, 2024
Merged
@sotnikov-s
Copy link
Contributor

https://github.com/neutron-org/neutron-tests/actions/runs/9320148190

@sotnikov-s sotnikov-s force-pushed the feat/improve-balances-query branch from 54a1449 to cfbdad2 Compare June 6, 2024 10:42
@sotnikov-s
Copy link
Contributor

https://github.com/neutron-org/neutron-tests/actions/runs/9320148190

@pr0n00gler pr0n00gler merged commit 1c7d274 into main Jun 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotnikov-s sotnikov-s sotnikov-s approved these changes

@NeverHappened NeverHappened NeverHappened approved these changes

@pr0n00gler pr0n00gler Awaiting requested review from pr0n00gler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ratik @sotnikov-s @NeverHappened @pr0n00gler