Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve balances query #130

Merged
merged 15 commits into from
Jun 6, 2024
Merged

feat: improve balances query #130

merged 15 commits into from
Jun 6, 2024

Conversation

ratik
Copy link
Contributor

@ratik ratik commented Feb 22, 2024 •
edited by sotnikov-s
Loading

this PR:

  • deprecates the SDK's new_register_balance_query_msg helper
  • adds a new new_register_balances_query_msg that accepts a list of denoms to query balances of
  • fixes v045 Balance reconstruction for empty values

related PRs:

pr0n00gler
pr0n00gler requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a separate method for this, not replacing the old one, cause otherwise the change is not backwards compatible

@ratik ratik requested a review from pr0n00gler February 22, 2024 08:44
@pr0n00gler
Copy link
Collaborator

And let's mark it as deprecated, please

@ratik ratik force-pushed the feat/improve-balances-query branch from 7302435 to 5a58a2c Compare February 22, 2024 10:58
@ratik ratik force-pushed the feat/improve-balances-query branch from 5a58a2c to a5c2d89 Compare February 22, 2024 11:02
@ratik ratik requested a review from albertandrejev February 22, 2024 11:31
albertandrejev
albertandrejev previously approved these changes Feb 22, 2024
View reviewed changes
pr0n00gler
pr0n00gler reviewed Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

albertandrejev
albertandrejev previously approved these changes Feb 22, 2024
View reviewed changes
pr0n00gler
pr0n00gler previously approved these changes Feb 22, 2024
View reviewed changes
@ratik
Copy link
Contributor Author

ratik commented Feb 22, 2024

image image

@ratik ratik dismissed stale reviews from pr0n00gler and albertandrejev via 0f396a9 February 22, 2024 14:32
albertandrejev
albertandrejev previously approved these changes Feb 22, 2024
View reviewed changes
@ratik ratik mentioned this pull request Feb 22, 2024
Merged
@ratik
Copy link
Contributor Author

ratik commented Feb 25, 2024

Test run

sotnikov-s
sotnikov-s requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to

  1. extend ICQ contract's interface to accept a list of denoms for balances query
  2. add integration tests covering multiple denoms and response with a zero value balance

will handle it myself later

@sotnikov-s sotnikov-s mentioned this pull request May 31, 2024
Merged
@sotnikov-s
Copy link
Contributor

https://github.com/neutron-org/neutron-tests/actions/runs/9320148190

sotnikov-s
sotnikov-s previously approved these changes Jun 3, 2024
View reviewed changes
NeverHappened
NeverHappened previously approved these changes Jun 4, 2024
View reviewed changes
@sotnikov-s sotnikov-s dismissed stale reviews from NeverHappened and themself via f847230 June 5, 2024 08:46
@pr0n00gler pr0n00gler merged commit ed3d135 into main Jun 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotnikov-s sotnikov-s sotnikov-s approved these changes

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@NeverHappened NeverHappened NeverHappened approved these changes

@albertandrejev albertandrejev albertandrejev left review comments

@foxpy foxpy Awaiting requested review from foxpy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ratik @pr0n00gler @sotnikov-s @NeverHappened @albertandrejev