Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rewrite dex_stargate and stargate_querier to use new helpers #NTRN-326 #59

Merged
merged 6 commits into from
Aug 13, 2024
Merged

feat: rewrite dex_stargate and stargate_querier to use new helpers #NTRN-326 #59

merged 6 commits into from
Aug 13, 2024

Conversation

pr0n00gler
Copy link
Collaborator

@pr0n00gler pr0n00gler commented Jul 19, 2024 •
edited by joldie777
Loading

Task: https://hadronlabs.atlassian.net/browse/NTRN-326

Related PRs:
neutron-org/neutron-sdk#156
neutron-org/neutron-integration-tests#329

List of changes:

  1. Rewrited dex_stargate and stargate_querier to use new helpers.
  2. Renamed dex_stargate and stargate_querier to dex_grpc and grpc_querier respectively.
  3. Regenerated schema.

@pr0n00gler pr0n00gler changed the title rewrite dex_stargate to use new helpers [WIP] rewrite dex_stargate to use new helpers Jul 19, 2024
@joldie777 joldie777 mentioned this pull request Jul 30, 2024
Closed
@joldie777 joldie777 changed the title [WIP] rewrite dex_stargate to use new helpers feat: rewrite dex_stargate and stargate_querier to use new helpers #NTRN-326 Jul 30, 2024
@joldie777 joldie777 mentioned this pull request Jul 30, 2024
Merged
@joldie777 joldie777 marked this pull request as ready for review July 30, 2024 15:11
@joldie777 joldie777 mentioned this pull request Jul 30, 2024
Merged
@joldie777 joldie777 force-pushed the feat/remove-stargate branch from 7a56086 to 29da5e4 Compare July 30, 2024 16:19
@joldie777
Copy link
Contributor

Test run: https://github.com/neutron-org/neutron-tests/actions/runs/10176822282

@NeverHappened
Copy link
Contributor

see conflicts in Makefile, please fix

pr0n00gler
pr0n00gler commented Aug 6, 2024
View reviewed changes
Copy link
Collaborator Author

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't approve it, since i've create the PR

@pr0n00gler pr0n00gler merged commit 0821807 into main Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joldie777 joldie777 joldie777 approved these changes

@NeverHappened NeverHappened NeverHappened approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pr0n00gler @joldie777 @NeverHappened