Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix tests accordingly to new contract schema #NTRN-326 #329

Merged
merged 9 commits into from
Aug 13, 2024
Merged

feat: fix tests accordingly to new contract schema #NTRN-326 #329

merged 9 commits into from
Aug 13, 2024

Conversation

pr0n00gler
Copy link
Collaborator

@pr0n00gler pr0n00gler commented Jul 19, 2024 •
edited by joldie777
Loading

Task: https://hadronlabs.atlassian.net/browse/NTRN-326

Related PRs:
neutron-org/neutron-sdk#156
neutron-org/neutron-dev-contracts#59

List of changes:

  1. Fixed tests for dex_stargate and stargate_querier contracts.
  2. Renamed dex_stargate.test.ts and stargate_queries.test.ts to dex_grpc.test.ts and grpc_queries.test.ts respectively.

@pr0n00gler pr0n00gler marked this pull request as draft July 19, 2024 14:03
This was referenced Jul 30, 2024
Closed
Merged
Merged
@joldie777 joldie777 changed the title [WIP] fix tests accordingly to new contract schema feat: fix tests accordingly to new contract schema #NTRN-326 Jul 30, 2024
@joldie777 joldie777 force-pushed the feat/remove-stargate branch 2 times, most recently from 31e4e77 to ff023b7 Compare July 30, 2024 15:34
@joldie777 joldie777 marked this pull request as ready for review July 30, 2024 15:35
@joldie777 joldie777 force-pushed the feat/remove-stargate branch from ff023b7 to 598ecf3 Compare July 30, 2024 15:38
@joldie777
Copy link
Contributor

Test run: https://github.com/neutron-org/neutron-tests/actions/runs/10176822282

NeverHappened
NeverHappened previously approved these changes Aug 5, 2024
View reviewed changes
pr0n00gler
pr0n00gler commented Aug 6, 2024
View reviewed changes
Copy link
Collaborator Author

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't approve since i've opened the PR

joldie777
joldie777 previously approved these changes Aug 6, 2024
View reviewed changes
@joldie777 joldie777 dismissed stale reviews from NeverHappened and themself via f026a12 August 12, 2024 16:18
@joldie777
Copy link
Contributor

Test run: https://github.com/neutron-org/neutron-tests/actions/runs/10355673672

NeverHappened
NeverHappened requested changes Aug 12, 2024
View reviewed changes
src/testcases/parallel/grpc_queries.test.ts Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
src/testcases/parallel/grpc_queries.test.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@joldie777 joldie777 force-pushed the feat/remove-stargate branch from 4e85273 to 64425ed Compare August 13, 2024 10:51
@pr0n00gler pr0n00gler merged commit c533ce8 into main Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joldie777 joldie777 joldie777 left review comments

@NeverHappened NeverHappened NeverHappened approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pr0n00gler @joldie777 @NeverHappened