SW-5459: add a parameter for utc/tai time offset #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samahu
requested review from
twslankard,
celentes,
chrisbayruns,
mtswisher and
Krishtof-Korda
|
I am adding both @mtswisher and @Krishtof-Korda since they are familiar the issue about PTP and UTC/TAI time issue. |
* ptp: Add parameter for utc/tai offset in ptp mode. * Conditionally apply conversions to imu_gyro_ts for msg_ts.
Samahu
force-pushed
the
SW-5459-add-parameter-for-utc-tai-offset-in-ptp-mode
branch
from
bcba9dd
to
730f161
Compare
mtswisher
approved these changes
Aug 25, 2023
twslankard
approved these changes
Aug 25, 2023
Samahu
deleted the
SW-5459-add-parameter-for-utc-tai-offset-in-ptp-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
Summary of Changes
Validation
Use a sensor with PTP mode and a host machine with sync enabled.
The sensor timestamps and the host machine timestamp should match (on the order of 10 microseconds)