Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamoDB: Add table_exists parameter and extend documentation #237

Merged
merged 5 commits into from
Apr 18, 2024
Merged

DynamoDB: Add table_exists parameter and extend documentation #237

merged 5 commits into from
Apr 18, 2024

Conversation

MauriceBrg
Copy link
Contributor

@MauriceBrg MauriceBrg commented Apr 12, 2024 •
edited
Loading

  • Add table_exists parameter to DynamoDBSessionInterface (SESSION_DYNAMODB_TABLE_EXISTS) to support pre-existing tables and limited permissions
    • Add test to ensure that it works with a pre-existing table
    • Add test to ensure there's an error when the table doesn't exist
  • Extend documentation for DynamoDBSessionInterface
  • Fix typo in CONTRIBUTING.rst
  • Fixes DynamoDB retrieve session does not check for expiration time #240

See also the discussion with @Lxstr here: #214 (comment)

@MauriceBrg MauriceBrg mentioned this pull request Apr 12, 2024
Merged
@MauriceBrg MauriceBrg mentioned this pull request Apr 18, 2024
Open
Lxstr
Lxstr reviewed Apr 18, 2024
View reviewed changes
docs/config_reference.rst Outdated Show resolved Hide resolved
@Lxstr Lxstr mentioned this pull request Apr 18, 2024
Open
Lxstr
Lxstr approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Lxstr Lxstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Everything looking good to me, I'll merge to dev and also merge the equivalent PR for sqlalchemy before going up a version.

src/flask_session/dynamodb/dynamodb.py Show resolved Hide resolved
@Lxstr
Copy link
Contributor

Lxstr commented Apr 18, 2024

mind if i try a force push?

@MauriceBrg
Copy link
Contributor Author

Seems like my last commit with the doc fix didn't make it, is the PR still open for you? Maybe you can try to merge again...

@Lxstr
Copy link
Contributor

Lxstr commented Apr 18, 2024

So strange... but git kraken has done this to me before where it just randomly wont merge something

@Lxstr
Copy link
Contributor

Lxstr commented Apr 18, 2024

I think i'll reset and try again, using github

@Lxstr Lxstr force-pushed the ft-dynamodb-extended branch from dcc0de2 to 0001bb3 Compare April 18, 2024 08:29
@Lxstr Lxstr merged commit bc2fe67 into pallets-eco:development Apr 18, 2024
6 of 7 checks passed
@Lxstr
Copy link
Contributor

Lxstr commented Apr 18, 2024

Does that look, better? I used github but it made a merge back into the PR first, a bit annoying

@MauriceBrg
Copy link
Contributor Author

Yeah, seems like the latest changes are now in development and it's shown as merged :)

@MauriceBrg MauriceBrg deleted the ft-dynamodb-extended branch April 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxstr Lxstr Lxstr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DynamoDB retrieve session does not check for expiration time
2 participants
@MauriceBrg @Lxstr