Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.8 #373

Closed
wants to merge 20 commits into from
Closed

Drop Python 3.8 #373

wants to merge 20 commits into from

Conversation

JamesParrott
Copy link

Completes #372

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • [x ] Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@JamesParrott
Bump python to 3.9. Drop Python 3.8 trove classifier.
98bf30d
@JamesParrott
Bump minimum Python to 3.9.0 (drop 3.8) in README.rst
ef425e9
@JamesParrott
Describe dropping Python 3.8 in python_versions.rst
a0dc931
@JamesParrott
Merge pull request #1 from JamesParrott/patch-3
ac7168b 
Describe dropping Python 3.8 in python_versions.rst
@JamesParrott
Merge pull request #2 from JamesParrott/patch-2
3653b9e 
Bump minimum Python to 3.9.0 (drop 3.8) in README.rst
@JamesParrott
Merge pull request #3 from JamesParrott/patch-1
dfd2a96 
Bump python to 3.9.  Drop Python 3.8 trove classifier.
@JamesParrott
Remove Python 3.8 tests from CI
2d79991
@JamesParrott
Base Quart.default_config on flask.app.Flask.default_config
74003b3
@JamesParrott
Run Black and isort
229257c
@JamesParrott
Pin hypercorn to <=0.16.0
13a5a2b
@JamesParrott
Fix type annotations and overloads
dd26c09
@JamesParrott
Try to add in all required overloads for Request.get_data (not quite …
a765196 
…managed)
@JamesParrott
We added type hints to yo' type hints (yo dawg...).
9a1baab 
Try to fix:
 mypy: commands[0]> mypy src/quart/ tests/
src/quart/app.py:129: error: Incompatible import of "ParamSpec" (imported name has type "type[typing_extensions.ParamSpec]", local name has type "type[typing.ParamSpec]")  [assignment]
Found 1 error in 1 file (checked 57 source files)
@JamesParrott
Use type: ignore, instead of type hints for your type hints
789955b
@JamesParrott
Remove unused #type: ignore error
2b74e2d
@JamesParrott
Remove unused imports (run flake8)
d9f7994
@JamesParrott
Merge pull request #4 from JamesParrott/Use-Flask-default_config
52b7e49 
Use flask default config
@JamesParrott
Run CI
57eaa67
@JamesParrott
Run on manual dispatch
3024801
@JamesParrott
Update tests.yaml
efe7984
@pgjones pgjones mentioned this pull request Nov 14, 2024
Closed
@pgjones
Copy link
Member

pgjones commented Nov 14, 2024

Thanks, I've made slightly different changes in places (see main). This was very helpful though.

@pgjones pgjones closed this Nov 14, 2024
@JamesParrott
Copy link
Author

You're very welcome Phil.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesParrott @pgjones