planner: Fix predicate simplification panic caused by zero-argument expressions like rand()

[dash12653]

What problem does this PR solve?

Issue Number: close #56270

Problem Summary:

What changed and how does it work?

When checking predicate type in predicate simplification, it will use arg[0] to judge if the arg is *expression.Column, however, "rand()" has 0 argument, which will lead a panic.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Hi @dash12653. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @dash12653. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.6565%. Comparing base (c32c7b2) to head (91bed62).
Report is 201 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56947         +/-   ##
=================================================
- Coverage   73.3374%   58.6565%   -14.6810%     
=================================================
  Files          1638       1801        +163     
  Lines        453738     665866     +212128     
=================================================
+ Hits         332760     390574      +57814     
- Misses       100578     251338     +150760     
- Partials      20400      23954       +3554     

Flag	Coverage Δ
integration	38.9389% <100.0000%> (?)
unit	74.6726% <0.0000%> (+2.1192%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	55.2602% <ø> (+2.3124%)	⬆️
parser	∅ <ø> (∅)
br	52.9699% <ø> (+6.9710%)	⬆️

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[dash12653]

/retest

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-29 08:36:39.389562318 +0000 UTC m=+338912.228717865: ☑️ agreed by lance6716.
• 2024-11-14 07:43:06.793431048 +0000 UTC m=+514948.984300044: ☑️ agreed by AilinKid.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,hawkingrei,lance6716]
• pkg/planner/OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57618.