Dependency updates #884
clippy
16 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 16 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.1 (a28077b28 2023-12-04)
- cargo 1.74.1 (ecb9851af 2023-10-18)
- clippy 0.1.74 (a28077b 2023-12-04)
Annotations
Check failure on line 873 in src/types.rs
github-actions / clippy
this `impl` can be derived
error: this `impl` can be derived
--> src/types.rs:869:1
|
869 | / impl Default for RuleVerdict {
870 | | fn default() -> RuleVerdict {
871 | | RuleVerdict::Accept
872 | | }
873 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
852 + #[derive(Default)]
853 | pub enum RuleVerdict {
|
help: ...and mark the default variant
|
856 ~ #[default]
857 ~ Accept,
|
Check failure on line 830 in src/types.rs
github-actions / clippy
this `impl` can be derived
error: this `impl` can be derived
--> src/types.rs:826:1
|
826 | / impl Default for ChainPolicy {
827 | | fn default() -> ChainPolicy {
828 | | ChainPolicy::Accept
829 | | }
830 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `-D clippy::derivable-impls` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::derivable_impls)]`
= help: remove the manual implementation...
help: ...and instead derive it...
|
814 + #[derive(Default)]
815 | pub enum ChainPolicy {
|
help: ...and mark the default variant
|
818 ~ #[default]
819 ~ Accept,
|
Check failure on line 873 in src/types.rs
github-actions / clippy
this `impl` can be derived
error: this `impl` can be derived
--> src/types.rs:869:1
|
869 | / impl Default for RuleVerdict {
870 | | fn default() -> RuleVerdict {
871 | | RuleVerdict::Accept
872 | | }
873 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
852 + #[derive(Default)]
853 | pub enum RuleVerdict {
|
help: ...and mark the default variant
|
856 ~ #[default]
857 ~ Accept,
|
Check failure on line 830 in src/types.rs
github-actions / clippy
this `impl` can be derived
error: this `impl` can be derived
--> src/types.rs:826:1
|
826 | / impl Default for ChainPolicy {
827 | | fn default() -> ChainPolicy {
828 | | ChainPolicy::Accept
829 | | }
830 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `-D clippy::derivable-impls` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::derivable_impls)]`
= help: remove the manual implementation...
help: ...and instead derive it...
|
814 + #[derive(Default)]
815 | pub enum ChainPolicy {
|
help: ...and mark the default variant
|
818 ~ #[default]
819 ~ Accept,
|
Check failure on line 189 in src/nftables/process.rs
github-actions / clippy
the borrowed expression implements the required traits
error: the borrowed expression implements the required traits
--> src/nftables/process.rs:189:23
|
189 | .args(&["list", "ruleset"])
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["list", "ruleset"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
Check failure on line 154 in src/iptables/mod.rs
github-actions / clippy
use of `or_insert_with` to construct default value
error: use of `or_insert_with` to construct default value
--> src/iptables/mod.rs:154:26
|
154 | .or_insert_with(BTreeMap::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
Check failure on line 142 in src/iptables/mod.rs
github-actions / clippy
use of `or_insert_with` to construct default value
error: use of `or_insert_with` to construct default value
--> src/iptables/mod.rs:142:26
|
142 | .or_insert_with(BTreeMap::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unwrap_or_default)]`
Check failure on line 189 in src/nftables/process.rs
github-actions / clippy
the borrowed expression implements the required traits
error: the borrowed expression implements the required traits
--> src/nftables/process.rs:189:23
|
189 | .args(&["list", "ruleset"])
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["list", "ruleset"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
Check failure on line 1045 in src/iptables/process.rs
github-actions / clippy
deref which would be done by auto-deref
error: deref which would be done by auto-deref
--> src/iptables/process.rs:1045:64
|
1045 | append_rule(rule_discriminant, &*rule.table, &*rule.chain, &*rule.rule)
| ^^^^^^^^^^^ help: try: `&rule.rule`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check failure on line 1045 in src/iptables/process.rs
github-actions / clippy
deref which would be done by auto-deref
error: deref which would be done by auto-deref
--> src/iptables/process.rs:1045:50
|
1045 | append_rule(rule_discriminant, &*rule.table, &*rule.chain, &*rule.rule)
| ^^^^^^^^^^^^ help: try: `&rule.chain`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check failure on line 1045 in src/iptables/process.rs
github-actions / clippy
deref which would be done by auto-deref
error: deref which would be done by auto-deref
--> src/iptables/process.rs:1045:36
|
1045 | append_rule(rule_discriminant, &*rule.table, &*rule.chain, &*rule.rule)
| ^^^^^^^^^^^^ help: try: `&rule.table`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]`
Check failure on line 154 in src/iptables/mod.rs
github-actions / clippy
use of `or_insert_with` to construct default value
error: use of `or_insert_with` to construct default value
--> src/iptables/mod.rs:154:26
|
154 | .or_insert_with(BTreeMap::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
Check failure on line 142 in src/iptables/mod.rs
github-actions / clippy
use of `or_insert_with` to construct default value
error: use of `or_insert_with` to construct default value
--> src/iptables/mod.rs:142:26
|
142 | .or_insert_with(BTreeMap::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unwrap_or_default)]`
Check failure on line 1045 in src/iptables/process.rs
github-actions / clippy
deref which would be done by auto-deref
error: deref which would be done by auto-deref
--> src/iptables/process.rs:1045:64
|
1045 | append_rule(rule_discriminant, &*rule.table, &*rule.chain, &*rule.rule)
| ^^^^^^^^^^^ help: try: `&rule.rule`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check failure on line 1045 in src/iptables/process.rs
github-actions / clippy
deref which would be done by auto-deref
error: deref which would be done by auto-deref
--> src/iptables/process.rs:1045:50
|
1045 | append_rule(rule_discriminant, &*rule.table, &*rule.chain, &*rule.rule)
| ^^^^^^^^^^^^ help: try: `&rule.chain`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check failure on line 1045 in src/iptables/process.rs
github-actions / clippy
deref which would be done by auto-deref
error: deref which would be done by auto-deref
--> src/iptables/process.rs:1045:36
|
1045 | append_rule(rule_discriminant, &*rule.table, &*rule.chain, &*rule.rule)
| ^^^^^^^^^^^^ help: try: `&rule.table`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]`