chore: embedded the contents of ipay88-my.aar #10
Conversation
# Conflicts: # gradle.properties
vasi-twks
force-pushed
the
release/test-maven
branch
from
efa1818 to
8f6ce6f
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
semirp
force-pushed
the
release/test-maven
branch
from
cf4c207 to
e0489ef
Compare
|
Fyi, don't forget about ipay88's manifest. Needs to be merged into the wrapper one (I remember there were some permissions) |
semirp
force-pushed
the
release/test-maven
branch
from
e0489ef to
8d120b0
Compare
| namespace 'io.primer.ipay88' | ||
| compileSdkVersion 34 | ||
| // in order not to crash their SDK, we can use their namespace to correctly find R class | ||
| namespace 'com.androids.ipay' |
There was a problem hiding this comment.
There are solutions for this:
- unpack their code and load resources dynamically, then package it again
- unpack their code and put it inside our package - but some things should not be pushed or added to public repo
At the end this seems as the easiest solution.
| @@ -38,9 +39,15 @@ android { | |||
| } | |||
| } | |||
|
|
|||
| tasks.configureEach { task -> | |||
| if (task.name == "generateReleaseBuildConfig") { | |||
There was a problem hiding this comment.
We have to disable generation of new BuildConfig file as gradle does not allow duplicates.
Yeah, all of the permissions and activities were added to the new Manifest 👍 |
A bit of context about this PR.
Ipay88 do not host their aar on a repository manager, therefore from what I understood from Semir, we received an .aar from them, and we hosted that aar into artifactory then we loaded that dependency from artifactory.
As the goal is now to remove artifactory, we had two options.
The second version was chosen so this PR has inlined the required resources and the classes file.
From what I can tell, nol-pay is another wrapper that has embedded the dependencies this way.
From a testing perspective, a version suffixed with "-SNAPSHOT" was published into maven local, then added a dependency for the primer-sdk-android project.
The project compiles and runs.
I attempted to do a payment flow, with both the dependency library and the embedded library, the result was failed for both of them but that seems to be related to a server workflow.