Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extra information YAFC now requires. #58

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

DaleStan
Copy link
Contributor

@DaleStan DaleStan commented Nov 16, 2024

I just made a PR in YAFC that means it now needs to know what surfaces each entity can spawn on. This change provides enough information that YAFC can correctly spawn pY entities. controls that give more accurate information about spawning density might be preferable, but YAFC doesn't currently handle that information.

shpaass added a commit to shpaass/yafc-ce that referenced this pull request Nov 18, 2024
This is some more parts of #316. I think it covers all location
information required by dependency/milestone analysis, except
space-connections (which don't add any additional unlocks): It knows
that lava isn't accessible until you get to Vulcanus and knows that
Promethium science pack is accessible. It is happy loading new and
existing pY and SA projects, though the pY projects [need a change to
pypostprocessing](pyanodon/pypostprocessing#58).

In order to not break Space science when fixing Promethium science, I
had to implement these, both internally and in the UI:

![image](https://github.com/user-attachments/assets/51fbfe78-3784-41ca-9b11-cd0ea28b625b)
![image](https://github.com/user-attachments/assets/64dac276-6e2e-4051-b646-d0b78bbc68a7)
The vertical bar will connect as many horizontal OR bars as necessary.
Lists that are not separated by an OR bar (almost all of them) use the
standard AND behavior.

I also decided this (1364 pixels high) was bad

![image](https://github.com/user-attachments/assets/7f533d19-c14b-4791-8867-1034918d4151)
and changed it to this instead (down to 970 px)

![image](https://github.com/user-attachments/assets/358b6820-fcdd-4940-8921-bc394a49a97d)
@notnotmelon notnotmelon merged commit e9e016a into pyanodon:main Nov 19, 2024
3 checks passed
@DaleStan DaleStan deleted the yafc-fix branch November 19, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants