Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gitlab): ensure getPrList() runtime integrity #32291

Merged
merged 13 commits into from
Nov 25, 2024
Merged

fix(gitlab): ensure getPrList() runtime integrity #32291

merged 13 commits into from
Nov 25, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Update the runtime pr list when a pr is updated

Context

Ref: #32040

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository (locally)

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 7, 2024 14:19
rarkins
rarkins requested changes Nov 7, 2024
View reviewed changes
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see open conversations

@RahulGautamSingh RahulGautamSingh mentioned this pull request Nov 9, 2024
Merged
6 tasks
@RahulGautamSingh

This comment was marked as outdated.

Sign in to view
@RahulGautamSingh RahulGautamSingh marked this pull request as draft November 15, 2024 19:51
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 22, 2024 16:35
@RahulGautamSingh RahulGautamSingh changed the title refactor(gitlab): ensure getPrList() runtime integrity refactor(gitlab): ensure getPrList() runtime integrity Nov 24, 2024
@viceice viceice changed the title refactor(gitlab): ensure getPrList() runtime integrity fix(gitlab): ensure getPrList() runtime integrity Nov 24, 2024
@rarkins rarkins enabled auto-merge November 24, 2024 15:58
@secustor
Copy link
Collaborator

@rarkins You have to approves as you have requested changes

@rarkins rarkins added this pull request to the merge queue Nov 25, 2024
Merged via the queue into renovatebot:main with commit 7da4d76 Nov 25, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ssams pushed a commit to ssams/renovate that referenced this pull request Dec 2, 2024
@RahulGautamSingh @viceice @ssams
fix(gitlab): ensure getPrList() runtime integrity (renovatebot#32291)
78627a9 
Co-authored-by: Michael Kriese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@secustor secustor secustor approved these changes

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RahulGautamSingh @secustor @renovate-release @viceice @rarkins