refactor(platform/gitlab): fix api reponse type in createPr fn

[RahulGautamSingh]

Changes

Use correct return type in the createPr function. And fix the tests + snaps accordingly.

Context

Instead of using Pr & { iid: number} which works but is wrong cause many of the corresponding field in the actual repsonse from api has different names. Eg. source_branch in response but sourceBranch in type Pr.

This also means that we have been saving the pr info in wrong/incorrect form in the runtime config list as well as the snaps are based on this wrong structure which is not good.

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

please split test and code refactoring to separate PR so the risk for regression is much lower

[RahulGautamSingh]

please split test and code refactoring to separate PR so the risk for regression is much lower

For createPr function the types used are wrong as they do not match the response we get from the api, hence the test and snaps are wrong too. Cannot correct one without disturbing the other.

I have split the getPr and fetchPrList refactoring in another PR which do not affect any tests. But createPr will have to get both code and test refactor together.

[viceice]

blocked

[renovate-release]

🎉 This PR is included in version 39.26.2 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 39.26.2

Your semantic-release bot 📦🚀