Skip to content

chore: adapter client improvements #8183

chore: adapter client improvements

chore: adapter client improvements #8183

Triggered via pull request December 17, 2024 15:48
Status Cancelled
Total duration 8m 57s
Artifacts

pr_checks.yml

on: pull_request
Matrix: code_style
Matrix: ui-test / Playwright Tests
Fit to window
Zoom out
Zoom in

Annotations

22 errors and 11 warnings
code_style (typecheck)
'watchConnectors' is declared but its value is never read.
code_style (typecheck)
'mock' is declared but its value is never read.
code_style (typecheck)
@reown/appkit-adapter-wagmi#typecheck: command (/home/runner/work/appkit/appkit/packages/adapters/wagmi) /home/runner/setup-pnpm/node_modules/.bin/pnpm run typecheck exited (2)
code_style (typecheck)
'wagmiCore' is declared but its value is never read.
code_style (typecheck)
Process completed with exit code 2.
code_style (build:sample-apps)
The job was canceled because "typecheck" failed.
code_style (build:sample-apps)
The operation was canceled.
code_style (lint)
The job was canceled because "typecheck" failed.
code_style (lint)
The operation was canceled.
src/tests/client.test.ts > WagmiAdapter > WagmiAdapter - constructor and initialization > should set wagmi connectors: packages/adapters/wagmi/src/client.ts#L393
TypeError: config._internal.connectors.subscribe is not a function ❯ Proxy.watchConnectors ../../../node_modules/.pnpm/@Wagmi[email protected]_@[email protected]_@[email protected][email protected]_typescript@5_zrcf2hcdtodb2mc2xcl7scj5ku/node_modules/@wagmi/core/src/actions/watchConnectors.ts:19:38 ❯ WagmiAdapter.syncConnectors src/client.ts:393:5 ❯ src/tests/client.test.ts:105:15
src/tests/client.test.ts > WagmiAdapter > WagmiAdapter - constructor and initialization > should not set info property for injected connector: packages/adapters/wagmi/src/client.ts#L393
TypeError: config._internal.connectors.subscribe is not a function ❯ Proxy.watchConnectors ../../../node_modules/.pnpm/@Wagmi[email protected]_@[email protected]_@[email protected][email protected]_typescript@5_zrcf2hcdtodb2mc2xcl7scj5ku/node_modules/@wagmi/core/src/actions/watchConnectors.ts:19:38 ❯ WagmiAdapter.syncConnectors src/client.ts:393:5 ❯ src/tests/client.test.ts:132:25
test
Process completed with exit code 1.
ui-test / Playwright Tests (3, 5)
Canceling since a higher priority waiting request for 'Checks-3484' exists
ui-test / Playwright Tests (3, 5)
The operation was canceled.
ui-test / Playwright Tests (2, 5)
Canceling since a higher priority waiting request for 'Checks-3484' exists
ui-test / Playwright Tests (2, 5)
The operation was canceled.
ui-test / Playwright Tests (5, 5)
Canceling since a higher priority waiting request for 'Checks-3484' exists
ui-test / Playwright Tests (5, 5)
The operation was canceled.
ui-test / Playwright Tests (1, 5)
Canceling since a higher priority waiting request for 'Checks-3484' exists
ui-test / Playwright Tests (1, 5)
The operation was canceled.
ui-test / Playwright Tests (4, 5)
Canceling since a higher priority waiting request for 'Checks-3484' exists
ui-test / Playwright Tests (4, 5)
The operation was canceled.
code_style (danger)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (prettier)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (typecheck)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (lint): packages/adapters/solana/src/client.ts#L77
Variable name `emailEnabled` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/adapters/solana/src/client.ts#L78
Variable name `socialsEnabled` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/ui/src/composites/wui-transaction-visual/index.ts#L56
Variable name `haveTwoImages` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/ui/src/utils/TransactionUtil.ts#L32
Variable name `haveMultipleTransfers` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/ui/src/utils/TransactionUtil.ts#L33
Variable name `haveTwoTransfers` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/ui/src/utils/TransactionUtil.ts#L81
Variable name `haveTransfer` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/ui/src/utils/TransactionUtil.ts#L82
Variable name `haveMultipleTransfers` must have one of the following prefixes: is, has, can, should, will, did
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636