Skip to content

chore: serialize name and icon for wallet info #8207

chore: serialize name and icon for wallet info

chore: serialize name and icon for wallet info #8207

Triggered via pull request December 17, 2024 22:19
Status Success
Total duration 13m 41s
Artifacts

pr_checks.yml

on: pull_request
Matrix: code_style
Matrix: ui-test / Playwright Tests
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 21 warnings
tests/controllers/RouterController.test.ts > RouterController > should update state correctly on push() with data: packages/core/tests/controllers/RouterController.test.ts#L79
AssertionError: expected { view: 'ConnectingExternal', …(3) } to deeply equal { view: 'ConnectingExternal', …(3) } - Expected + Received Object { "data": Object { "connector": Object { "chain": "eip155", "id": "test", + "name": "wcConnector", "type": "WALLET_CONNECT", }, }, "history": Array [ "Account", "Networks", "ConnectingExternal", ], "transactionStack": Array [], "view": "ConnectingExternal", } ❯ tests/controllers/RouterController.test.ts:79:36
test
Process completed with exit code 1.
code_style (danger)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (prettier)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (typecheck)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (lint)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (lint): packages/siwe/src/client.ts#L22
Variable name `enabled` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/siwe/src/client.ts#L25
Variable name `signOutOnAccountChange` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/siwe/src/client.ts#L26
Variable name `signOutOnDisconnect` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/siwe/src/client.ts#L27
Variable name `signOutOnNetworkChange` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/wallet-button/src/scaffold-ui/appkit-wallet-button/index.ts#L90
Variable name `walletConnect` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/wallet-button/src/scaffold-ui/appkit-wallet-button/index.ts#L92
Variable name `loading` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/wallet-button/src/utils/ConnectorUtil.ts#L78
Variable name `connectingSocial` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/adapters/wagmi/src/client.ts#L223
Variable name `emailEnabled` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/adapters/wagmi/src/client.ts#L380
Variable name `injectedConnector` must have one of the following prefixes: is, has, can, should, will, did
code_style (lint): packages/ui/src/composites/wui-transaction-visual/index.ts#L56
Variable name `haveTwoImages` must have one of the following prefixes: is, has, can, should, will, did
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
code_style (build:sample-apps)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
ui-test / Playwright Tests (1, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (5, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (2, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (3, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ui-test / Playwright Tests (4, 5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/