-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React Native 0.72.17 #267
Open
lancesnider
wants to merge
14
commits into
main
Choose a base branch
from
chore-upgrade-rn--0.72.17
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6e84f2a
chore: upgrade rive-react-native in example project
lancesnider ea134fe
chore: remove deprecated tsconfig option
lancesnider 3038b83
chore: upgrade jes
lancesnider 273198a
chore: upgrade pod-install
lancesnider 118069b
chore: upgrade realease-it and @release-it/conventional-changelog
lancesnider 4f05779
chore: upgrade react-native-codegen
lancesnider 7fcc156
chore: upgrade react-native-builder-bob
lancesnider 755f17c
chore: upgrade @tsconfig/react-native
lancesnider 076b8d9
chore: install new version of husky
lancesnider ee31df8
chore: husky - add precommit rules and messages
lancesnider 9b35877
chore: upgrade react-native to 0.72.17
lancesnider a081c5b
chore: upgrade the react-native package
lancesnider 0be03e6
chore: add comments for the podfile workaround
lancesnider 7f42007
chore: add correct eslint ignore for rive.tsx
lancesnider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
commitlint --edit $1 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
yarn lint | ||
yarn typescript |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { isEnum } from '../helpers'; | ||
|
||
describe('isEnum function', () => { | ||
enum TestEnum { | ||
ValueA = 'A', | ||
ValueB = 'B', | ||
ValueC = 'C', | ||
} | ||
|
||
it('should return true for a valid enum value', () => { | ||
expect(isEnum(TestEnum, 'A')).toBe(true); | ||
expect(isEnum(TestEnum, 'B')).toBe(true); | ||
expect(isEnum(TestEnum, 'C')).toBe(true); | ||
}); | ||
|
||
it('should return false for an invalid enum value', () => { | ||
expect(isEnum(TestEnum, 'D')).toBe(false); | ||
expect(isEnum(TestEnum, 'E')).toBe(false); | ||
expect(isEnum(TestEnum, '')).toBe(false); | ||
expect(isEnum(TestEnum, 'ValueB')).toBe(false); | ||
}); | ||
|
||
it('should handle non-string inputs gracefully', () => { | ||
expect(isEnum(TestEnum, null as any)).toBe(false); | ||
expect(isEnum(TestEnum, undefined as any)).toBe(false); | ||
expect(isEnum(TestEnum, 123 as any)).toBe(false); | ||
}); | ||
}); |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,6 @@ | |
"allowUnreachableCode": false, | ||
"allowUnusedLabels": false, | ||
"esModuleInterop": true, | ||
"importsNotUsedAsValues": "error", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Deprecated in the next version of |
||
"forceConsistentCasingInFileNames": true, | ||
"jsx": "react", | ||
"lib": ["esnext"], | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the new .husky/pre-commit files do the same thing that this used to: