Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Native 0.72.17 #267

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

lancesnider
Copy link
Contributor

@lancesnider lancesnider commented Sep 25, 2024

Before we start upgrading to React Native 0.73.x and 0.74.x, we want to get everything upgrades to the latest version of 0.72.x. This PR:

  • Upgrade React Native from 0.72.7 to 0.72.17 based on the upgrade helper.
  • Upgrade all of our dev dependencies as high as they can go while still supporting node 16.
  • Add a workaround for the Flipper issue described here. This is a temporary fix that we can remove when we upgrade React Native to 0.74.x.
  • Add tests so that yarn test no longer fails.

Testing

Note: This'll only work on projects using RN <= 0.72

Run yarn test

  1. Remove node_modules in the parent director and inside examples/
  2. Remove /examples/ios/Pods
  3. Run yarn bootstrap
  4. Open an Android emulator in Android Studio (any phone)
  5. Run yarn example start
  6. When Expo is ready, click i to start an iOS simulator and/or a to start an Android

You might have an issue where Expo tries to run on a previously used device, rather than a Simulator. If that happens, run yarn example ios --simulator="iPhone 15" (or whatever device).

To test on a real device, open example/ios/RiveReactNativeExample.xcworkspace in XCode.

@@ -0,0 +1 @@
commitlint --edit $1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the new .husky/pre-commit files do the same thing that this used to:

"husky": {
    "hooks": {
      "commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
      "pre-commit": "yarn lint && yarn typescript"
    }
  },

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file happen automatically when running yarn bootstrap.

@@ -7,7 +7,6 @@
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"esModuleInterop": true,
"importsNotUsedAsValues": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in the next version of typescript.

Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants