-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React Native 0.72.17 #267
base: main
Are you sure you want to change the base?
Conversation
Option 'importsNotUsedAsValues' is deprecated and will stop functioning in TypeScript 5.5
This commit also includes tests for the isEnum helper function
Upgrades to the latest versions that still support node 16
When upgrading from 4, they recommend starting from scratch
@@ -0,0 +1 @@ | |||
commitlint --edit $1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the new .husky/pre-commit files do the same thing that this used to:
"husky": {
"hooks": {
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
"pre-commit": "yarn lint && yarn typescript"
}
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file happen automatically when running yarn bootstrap
.
@@ -7,7 +7,6 @@ | |||
"allowUnreachableCode": false, | |||
"allowUnusedLabels": false, | |||
"esModuleInterop": true, | |||
"importsNotUsedAsValues": "error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated in the next version of typescript
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this
Before we start upgrading to React Native
0.73.x
and0.74.x
, we want to get everything upgrades to the latest version of0.72.x
. This PR:0.72.7
to0.72.17
based on the upgrade helper.0.74.x
.yarn test
no longer fails.Testing
Note: This'll only work on projects using RN <= 0.72
Run
yarn test
node_modules
in the parent director and insideexamples/
/examples/ios/Pods
yarn bootstrap
yarn example start
i
to start an iOS simulator and/ora
to start an AndroidYou might have an issue where Expo tries to run on a previously used device, rather than a Simulator. If that happens, run
yarn example ios --simulator="iPhone 15"
(or whatever device).To test on a real device, open
example/ios/RiveReactNativeExample.xcworkspace
in XCode.