Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ui only documentation #311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kevinlinxc
Copy link
Contributor

Since the removal of ui only was merged (rubygems/rubygems.org#3084), the guides should be updated.

I remove other mentions of it and only talk about it in the place where dropdown is mentioned, explaining that it will still show up for people that have it as their set MFA level. Perhaps this bit is unnecessary but it feels like harmless transparency.

Another idea that I think we should do is link the ui only removal blog post.

- **UI and gem signin**: UI operations and `gem signin` will require OTP code.
- **UI and API**: UI operations, `gem signin`, `push`, `owner --add` and `owner --remove` will require OTP code.

Note: If you are on the **UI only** or **UI and gem signin** authentication level,
UI Only was previously a valid MFA level, however, it has been removed and only accounts that were previously at that level will still see it in the dropdown.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine the blog post as being linked on removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any opinions on whether a blog post should be linked before this gets merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be a new PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it would need to be created in the blog repo here: https://github.com/rubygems/rubygems.github.io. Would you like to write up a draft since you worked on this?

Clarifying on my original question, do you have a preference on the merge order? ie. merging this before the blog post has been posted and adding the link after or waiting until the blog has been merged and then merging this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I undercommunicated. I meant that I think the blog post linking could be a new pull request after this PR is merged. As for writing the blog post, I could do it, but I don't yet understand why UI only is insecure. Is it just that the CLI usage is more common?

@kevinlinxc
Copy link
Contributor Author

kevinlinxc commented Jun 21, 2022

image

Copy link
Member

@jenshenny jenshenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kevinlinxc

setting-up-multifactor-authentication.md Outdated Show resolved Hide resolved
- **UI and gem signin**: UI operations and `gem signin` will require OTP code.
- **UI and API**: UI operations, `gem signin`, `push`, `owner --add` and `owner --remove` will require OTP code.

Note: If you are on the **UI only** or **UI and gem signin** authentication level,
UI Only was previously a valid MFA level, however, it has been removed and only accounts that were previously at that level will still see it in the dropdown.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any opinions on whether a blog post should be linked before this gets merged?

@kevinlinxc
Copy link
Contributor Author

Ok, we wrote the blog post, so we might as well wait for it and link it.
So, this PR is blocked by rubygems/rubygems.github.io#119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants