Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Aug 14, 2024

Now that Enterprise Portal is a source of truth, there is no longer any need to have any dotcomdb mechanisms available - this deletes everything around dotcomdb and also removes the testing infrastructure that was set up to backcompat-test the Cody Gateway access APIs like the dotcomproductsubscriptiontest package.

Part of https://linear.app/sourcegraph/issue/CORE-252

Test plan

CI, and the E2E suite for EP now works with only Enterprise Portal running:

sg start -cmd enterprise-portal
sg test enterprise-portal-e2e

@bobheadxi bobheadxi requested a review from a team August 14, 2024 23:58
@cla-bot cla-bot bot added the cla-signed label Aug 14, 2024
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo!

@bobheadxi bobheadxi force-pushed the enterpriseportal-remove-dotcomdb-stuff branch from 0678095 to 0d8d554 Compare August 16, 2024 02:43
@bobheadxi bobheadxi changed the base branch from main to 08-12-feat_dotcom_forward_license_check_to_enterprise_portal August 16, 2024 02:43
Copy link
Contributor

Warning

Test ownership level below 70% on this branch.

We aim to have ~70% of Bazel test targets to help us (dev-infra) and you get insight into the impact of tests on CI times. This is a non-blocking requirement, but keeping on top of test attribution to maintain this threshold is appreciated.

See the list of tag variable names to use here, and reach out to #discuss-dev-infra if you need to add/change this list.

See an example of how to use the variables here.

@bobheadxi bobheadxi force-pushed the 08-12-feat_dotcom_forward_license_check_to_enterprise_portal branch from 14f4332 to 781359d Compare August 16, 2024 16:37
@bobheadxi bobheadxi force-pushed the enterpriseportal-remove-dotcomdb-stuff branch from 0d8d554 to bce7c55 Compare August 16, 2024 16:37
@bobheadxi bobheadxi force-pushed the 08-12-feat_dotcom_forward_license_check_to_enterprise_portal branch from 781359d to 6128d2f Compare August 16, 2024 17:02
@bobheadxi bobheadxi force-pushed the enterpriseportal-remove-dotcomdb-stuff branch from bce7c55 to 9fd2a8e Compare August 16, 2024 17:02
@bobheadxi bobheadxi force-pushed the 08-12-feat_dotcom_forward_license_check_to_enterprise_portal branch from 6128d2f to 0ea16ab Compare August 16, 2024 18:18
@bobheadxi bobheadxi force-pushed the enterpriseportal-remove-dotcomdb-stuff branch from 9fd2a8e to 05176c8 Compare August 16, 2024 18:18
@bobheadxi bobheadxi closed this Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants