This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore/enterpriseportal: remove dotcomdb connection and testing infra #64479
Closed
bobheadxi
wants to merge
2
commits into
08-12-feat_dotcom_forward_license_check_to_enterprise_portal
from
enterpriseportal-remove-dotcomdb-stuff
Closed
chore/enterpriseportal: remove dotcomdb connection and testing infra #64479
bobheadxi
wants to merge
2
commits into
08-12-feat_dotcom_forward_license_check_to_enterprise_portal
from
enterpriseportal-remove-dotcomdb-stuff
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknwon
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eseliger
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo!
bobheadxi
force-pushed
the
enterpriseportal-remove-dotcomdb-stuff
branch
from
August 16, 2024 02:43
0678095
to
0d8d554
Compare
bobheadxi
changed the base branch from
main
to
08-12-feat_dotcom_forward_license_check_to_enterprise_portal
August 16, 2024 02:43
This was referenced Aug 16, 2024
This was referenced Aug 16, 2024
Warning Test ownership level below 70% on this branch. We aim to have ~70% of Bazel test targets to help us (dev-infra) and you get insight into the impact of tests on CI times. This is a non-blocking requirement, but keeping on top of test attribution to maintain this threshold is appreciated. See the list of tag variable names to use here, and reach out to #discuss-dev-infra if you need to add/change this list. See an example of how to use the variables here. |
bobheadxi
force-pushed
the
08-12-feat_dotcom_forward_license_check_to_enterprise_portal
branch
from
August 16, 2024 16:37
14f4332
to
781359d
Compare
bobheadxi
force-pushed
the
enterpriseportal-remove-dotcomdb-stuff
branch
from
August 16, 2024 16:37
0d8d554
to
bce7c55
Compare
bobheadxi
force-pushed
the
08-12-feat_dotcom_forward_license_check_to_enterprise_portal
branch
from
August 16, 2024 17:02
781359d
to
6128d2f
Compare
bobheadxi
force-pushed
the
enterpriseportal-remove-dotcomdb-stuff
branch
from
August 16, 2024 17:02
bce7c55
to
9fd2a8e
Compare
bobheadxi
force-pushed
the
08-12-feat_dotcom_forward_license_check_to_enterprise_portal
branch
from
August 16, 2024 18:18
6128d2f
to
0ea16ab
Compare
bobheadxi
force-pushed
the
enterpriseportal-remove-dotcomdb-stuff
branch
from
August 16, 2024 18:18
9fd2a8e
to
05176c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Enterprise Portal is a source of truth, there is no longer any need to have any dotcomdb mechanisms available - this deletes everything around dotcomdb and also removes the testing infrastructure that was set up to backcompat-test the Cody Gateway access APIs like the
dotcomproductsubscriptiontest
package.Part of https://linear.app/sourcegraph/issue/CORE-252
Test plan
CI, and the E2E suite for EP now works with only Enterprise Portal running: