This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: define SubscriptionLicenseChecksService #64396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2024
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
ef80872 to
a05b35b
Compare
eseliger
approved these changes
Aug 9, 2024
| load("@rules_proto_grpc//doc:defs.bzl", "doc_template_compile") | ||
| load("@rules_buf//buf:defs.bzl", "buf_lint_test") | ||
|
|
||
| # Bazel-generated files are different from what is generated locally by buf and |
There was a problem hiding this comment.
the issue mentioned in the docstring https://github.com/sourcegraph/devx-support/issues/932 has an archive of my debugging efforts. tl;dr i'm not sure, and the bazel-generated files are invalid, causing everything to fail to build if you use Bazel but not if you use Go
bobheadxi
force-pushed
the
08-02-feat_enterpriseportal_add_instance_category
branch
2 times, most recently
from
ed907cc to
958195f
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
a05b35b to
f07d4ff
Compare
2 tasks
bobheadxi
force-pushed
the
08-02-feat_enterpriseportal_add_instance_category
branch
from
958195f to
e4eaa6e
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
3 times, most recently
from
da734d3 to
9d3d1e1
Compare
Base automatically changed from
08-02-feat_enterpriseportal_add_instance_category
to
main
August 10, 2024 01:19
|
Discussed with @eseliger offline, I'm introducing another change here:
For now, this parameter will support the existing format so we can forward checks in dotcom to EP, but I've set a target removal release |
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
3 times, most recently
from
d8b3432 to
8e0f2d9
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
8e0f2d9 to
9f29a98
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
2 times, most recently
from
f15b76f to
1ebd646
Compare
unknwon
approved these changes
Aug 15, 2024
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
2 times, most recently
from
01de0f8 to
ba89637
Compare
bobheadxi
force-pushed
the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
from
ba89637 to
fab52ee
Compare
This was referenced Aug 15, 2024
bobheadxi
deleted the
08-09-feat_enterpriseportal_define_subscriptionlicensechecksservice
branch
bobheadxi
referenced
this pull request
Aug 16, 2024
…4400) Implements the RPC defined in https://github.com/sourcegraph/sourcegraph/pull/64396. Follow-up PRs will implement migrations for in-instance checks and for through-dotcom checks. One major change is that we now bypass the check for subscriptions that are denoted as associated with `INTERNAL` instances. Most of the diff is generated mocks. Part of https://linear.app/sourcegraph/issue/CORE-227 ## Test plan - [x] Unit tests - [x] E2E tests (`sg test enterprise-portal-e2e`) 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines an Enterprise Portal version of the "license check" API that is currently bundled in Souregraph as a separate gRPC service that will be implemented in Enterprise Portal (in a PR I will stack on top of this one). The API schema is pretty much the same, except:
errorfield, since I'm pretty sure we can return a real error instead in a connectRPC implementation for the same effect.license_keya parameter, as we already propagate the license key all over the place (pings, telemetry) - this is a fairly low-frequency check so there shouldn't be any bandwidth concerns or the like. For now, this parameter will support the existing format so we can forward checks in dotcom to EP, but I've set a target removal releaseExisting API: https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/cmd/frontend/internal/dotcom/productsubscription/license_check_handler.go?L133
Part of https://linear.app/sourcegraph/issue/CORE-227
Test plan
CI