This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: existing subscriptions read APIs use enterprise portal DB #63927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
670d4a8
to
07f6ae6
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_implement_updatecodygatewayaccess
branch
from
e81f272
to
a5c9edb
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
07f6ae6
to
d3fb2dd
Compare
bobheadxi
commented
Jul 18, 2024
cmd/enterprise-portal/internal/subscriptionsservice/adapters.go
Outdated
Show resolved
Hide resolved
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_implement_updatecodygatewayaccess
branch
from
a5c9edb
to
e786e7a
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
d3fb2dd
to
8b66e31
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_implement_updatecodygatewayaccess
branch
from
e786e7a
to
889233c
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
2 times, most recently
from
cfe855b
to
4737a65
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_implement_updatecodygatewayaccess
branch
from
a42857f
to
6bb1bea
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
4737a65
to
7e86a43
Compare
bobheadxi
changed the title
3 tasks
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
7e86a43
to
152047a
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_implement_updatecodygatewayaccess
branch
from
2fa6111
to
5726960
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
152047a
to
16bc317
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_implement_updatecodygatewayaccess
branch
from
5726960
to
8745870
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
16bc317
to
d0bce4c
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
ca8c93e
to
fe03bfa
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
e42c135
to
1e5b1db
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
fe03bfa
to
c250b14
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
1e5b1db
to
37b37b8
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
c250b14
to
2b1b8dd
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
37b37b8
to
aefc7d3
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
2b1b8dd
to
81f431a
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
aefc7d3
to
bedab7c
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
81f431a
to
6c13f2f
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
bedab7c
to
289be88
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
6c13f2f
to
79ccb57
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
289be88
to
17c6e81
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
79ccb57
to
edbc2b3
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
17c6e81
to
355e3ea
Compare
bobheadxi
force-pushed
the
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
branch
from
edbc2b3
to
0cb9ba0
Compare
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
355e3ea
to
9fb78d7
Compare
Base automatically changed from
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
to
main
August 9, 2024 16:16
bobheadxi
force-pushed
the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
from
9fb78d7
to
092b9f2
Compare
bobheadxi
deleted the
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
branch
This was referenced Aug 9, 2024
unknwon
reviewed
Aug 14, 2024
| @@ -121,7 +121,6 @@ func (Service) Initialize(ctx context.Context, logger log.Logger, contract runti | |||
| subscriptionsservice.NewStoreV1( | |||
| subscriptionsservice.NewStoreV1Options{ | |||
| DB: dbHandle, | |||
| DotcomDB: dotcomDB, | |||
This was referenced Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows https://github.com/sourcegraph/sourcegraph/pull/63858 by making the existing subscriptions APIs read from the Enterprise Portal database, instead of dotcomdb, using the data that we sync from dotcomdb into Enterprise Portal.
Part of https://linear.app/sourcegraph/issue/CORE-156
Part of https://linear.app/sourcegraph/issue/CORE-158
Test plan
Updated unit and integration tests