PHPStan level 10 part I #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaze
force-pushed
the
spaze/phpstan-level-10
branch
from
054c285 to
3c1d6b8
Compare
…() for better type support
It would be enough to use
```
if (!$collator instanceof Collator) {
```
instead of just
```
if (!$collator) {
```
But why not remove `static $collator` as well.
This fixes "Cannot call method getSortKey() on mixed."
Similar to how it's done with ARES.
spaze
force-pushed
the
spaze/phpstan-level-10
branch
from
3c1d6b8 to
404e8a2
Compare
spaze
added a commit
that referenced
this pull request
Dec 19, 2024
_A few weeks and +10% test coverage later..._ Bring the rest of the code to PHPStan level 10 (follow-up to #443). The level is bumped back to `max` in this PR. Several bugs were found and taken care of during the effort, mostly because I've added more tests, but without the effort of going to level 10, I would have written no additional tests because why 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the code for PHPStan to pass at the new level 10 introduced in PHPStan 2.0 (#431). The level is not set to 10 yet in this PR (Done in the follow-up PR #446).
Besides some other things, this adds
assert()calls to assert types for database rows and form field values. Tests are also added to make sure these asserts are correct.