PHPStan level 10 part II #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #279
I don't think it ever worked but now it's fixed thanks to the PHPStan Level 10 effort (and tests).
PR'd phpstan/phpstan-nette#166 and this can be removed once the PR is merged and deployed.
A few weeks and +10% test coverage later.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks and +10% test coverage later...
Bring the rest of the code to PHPStan level 10 (follow-up to #443). The level is bumped back to
maxin this PR.Several bugs were found and taken care of during the effort, mostly because I've added more tests, but without the effort of going to level 10, I would have written no additional tests because why 😅