Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pixi support #2459

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Add pixi support #2459

merged 13 commits into from
Oct 28, 2024

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Oct 16, 2024 •
edited
Loading

This PR add Pixi support for developer and CI.

This aims to have:

Bonus:

  • Fix cppad and cppadcg build with last cppad version.
  • Fix mjcf unittest fail with last boost version
  • Fix sincos test fail on OSX Debug
  • Fix constraint-variants test fail on Linux (uninitialized values)
  • Fix mixing binding symbol issue on OSX Debug (Set -fvisibility=hidden on OSX and GNU/Linux #2462)

TODO:

  • pixi.toml
  • debug cppad/cppadcg finder
  • CI
  • README.md
  • lockfile update bot

@jorisv jorisv self-assigned this Oct 16, 2024
github-actions[bot]
github-actions bot reviewed Oct 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@jorisv jorisv force-pushed the topic/pixi branch 4 times, most recently from 3122709 to 6b8ff4d Compare October 23, 2024 15:55
@jorisv jorisv marked this pull request as ready for review October 25, 2024 15:03
@jorisv jorisv merged commit 68166cc into stack-of-tasks:devel Oct 28, 2024
23 checks passed
@jorisv jorisv deleted the topic/pixi branch October 28, 2024 14:38
@jorisv jorisv mentioned this pull request Oct 28, 2024
Closed
nim65s added a commit to nim65s/robotpkg that referenced this pull request Nov 8, 2024
@nim65s
[math/{py-,}pinocchio] Update to v3.3.0
c20fc90 
    ## [3.3.0] - 2024-11-06

    ### Added

    - Default visualizer can be changed with `PINOCCHIO_VIEWER` environment variable stack-of-tasks/pinocchio#2419
    - Add more Python and C++ examples related to inverse kinematics with 3d tasks stack-of-tasks/pinocchio#2428
    - Add parsing of equality/connect tag for closed-loop chains for MJCF format stack-of-tasks/pinocchio#2413
    - Add compatibility with NumPy 2 `__array__` API stack-of-tasks/pinocchio#2436
    - Added argument to let users decide of root joint name when parsing models (urdf, mjcf, sdf) stack-of-tasks/pinocchio#2402
    - Allow use of `pathlib.Path | str` for paths in python bindings stack-of-tasks/pinocchio#2431
    - Add Pseudo inertia and Log-cholesky parametrization stack-of-tasks/pinocchio#2296
    - Add Pixi support stack-of-tasks/pinocchio#2459

    ### Fixed
    - Fix linkage of Boost.Serialization on Windows stack-of-tasks/pinocchio#2400
    - Fix mjcf parser appending of inertias at root joint stack-of-tasks/pinocchio#2403
    - Fix unit tests with GCC 13.3 stack-of-tasks/pinocchio#2416)
    - Fix class abstract error for Rviz viewer stack-of-tasks/pinocchio#2425
    - Fix compilation issue with MSCV and C++17 stack-of-tasks/pinocchio#2437
    - Fix `pinocchio-test-py-robot_wrapper` when building with SDF and collision support stack-of-tasks/pinocchio#2437
    - Fix crash when calling `Inertia::FromDynamicParameters` in Python with wrong vector size stack-of-tasks/pinocchio#2296
    - Fix `examples/cassie-simulation.py` and `examples/talos-simulation.py` stack-of-tasks/pinocchio#2443
    - Fix build with CppAd 2024 stack-of-tasks/pinocchio#2459
    - Fix `pinocchio-test-cpp-mjcf` unittest with Boost 1.86 stack-of-tasks/pinocchio#2459
    - Fix `pinocchio-test-cpp-constraint-variants` uninitialized values stack-of-tasks/pinocchio#2459
    - Fix mixing library symbols between Pinocchio scalar bindings stack-of-tasks/pinocchio#2459
    - Fix bug for get{Joint,Frame}JacobianTimeVariation stack-of-tasks/pinocchio#2466

    ### Changed

    - Modernize python code base with ruff stack-of-tasks/pinocchio#2418
    - Does not create a root_joint frame from parsed models (urdf, mjcf and sdf) when no root joint is provided stack-of-tasks/pinocchio#2402
nim65s added a commit to nim65s/robotpkg that referenced this pull request Nov 21, 2024
@nim65s
[math/{py-,}pinocchio] Update to v3.3.0
18b8898 
    ## [3.3.0] - 2024-11-06

    ### Added

    - Default visualizer can be changed with `PINOCCHIO_VIEWER` environment variable stack-of-tasks/pinocchio#2419
    - Add more Python and C++ examples related to inverse kinematics with 3d tasks stack-of-tasks/pinocchio#2428
    - Add parsing of equality/connect tag for closed-loop chains for MJCF format stack-of-tasks/pinocchio#2413
    - Add compatibility with NumPy 2 `__array__` API stack-of-tasks/pinocchio#2436
    - Added argument to let users decide of root joint name when parsing models (urdf, mjcf, sdf) stack-of-tasks/pinocchio#2402
    - Allow use of `pathlib.Path | str` for paths in python bindings stack-of-tasks/pinocchio#2431
    - Add Pseudo inertia and Log-cholesky parametrization stack-of-tasks/pinocchio#2296
    - Add Pixi support stack-of-tasks/pinocchio#2459

    ### Fixed
    - Fix linkage of Boost.Serialization on Windows stack-of-tasks/pinocchio#2400
    - Fix mjcf parser appending of inertias at root joint stack-of-tasks/pinocchio#2403
    - Fix unit tests with GCC 13.3 stack-of-tasks/pinocchio#2416)
    - Fix class abstract error for Rviz viewer stack-of-tasks/pinocchio#2425
    - Fix compilation issue with MSCV and C++17 stack-of-tasks/pinocchio#2437
    - Fix `pinocchio-test-py-robot_wrapper` when building with SDF and collision support stack-of-tasks/pinocchio#2437
    - Fix crash when calling `Inertia::FromDynamicParameters` in Python with wrong vector size stack-of-tasks/pinocchio#2296
    - Fix `examples/cassie-simulation.py` and `examples/talos-simulation.py` stack-of-tasks/pinocchio#2443
    - Fix build with CppAd 2024 stack-of-tasks/pinocchio#2459
    - Fix `pinocchio-test-cpp-mjcf` unittest with Boost 1.86 stack-of-tasks/pinocchio#2459
    - Fix `pinocchio-test-cpp-constraint-variants` uninitialized values stack-of-tasks/pinocchio#2459
    - Fix mixing library symbols between Pinocchio scalar bindings stack-of-tasks/pinocchio#2459
    - Fix bug for get{Joint,Frame}JacobianTimeVariation stack-of-tasks/pinocchio#2466

    ### Changed

    - Modernize python code base with ruff stack-of-tasks/pinocchio#2418
    - Does not create a root_joint frame from parsed models (urdf, mjcf and sdf) when no root joint is provided stack-of-tasks/pinocchio#2402
nim65s added a commit to nim65s/robotpkg that referenced this pull request Dec 6, 2024
@nim65s
[math/{py-,}pinocchio] Update to v3.3.0
2dae48c 
    ## [3.3.0] - 2024-11-06

    ### Added

    - Default visualizer can be changed with `PINOCCHIO_VIEWER` environment variable stack-of-tasks/pinocchio#2419
    - Add more Python and C++ examples related to inverse kinematics with 3d tasks stack-of-tasks/pinocchio#2428
    - Add parsing of equality/connect tag for closed-loop chains for MJCF format stack-of-tasks/pinocchio#2413
    - Add compatibility with NumPy 2 `__array__` API stack-of-tasks/pinocchio#2436
    - Added argument to let users decide of root joint name when parsing models (urdf, mjcf, sdf) stack-of-tasks/pinocchio#2402
    - Allow use of `pathlib.Path | str` for paths in python bindings stack-of-tasks/pinocchio#2431
    - Add Pseudo inertia and Log-cholesky parametrization stack-of-tasks/pinocchio#2296
    - Add Pixi support stack-of-tasks/pinocchio#2459

    ### Fixed
    - Fix linkage of Boost.Serialization on Windows stack-of-tasks/pinocchio#2400
    - Fix mjcf parser appending of inertias at root joint stack-of-tasks/pinocchio#2403
    - Fix unit tests with GCC 13.3 stack-of-tasks/pinocchio#2416)
    - Fix class abstract error for Rviz viewer stack-of-tasks/pinocchio#2425
    - Fix compilation issue with MSCV and C++17 stack-of-tasks/pinocchio#2437
    - Fix `pinocchio-test-py-robot_wrapper` when building with SDF and collision support stack-of-tasks/pinocchio#2437
    - Fix crash when calling `Inertia::FromDynamicParameters` in Python with wrong vector size stack-of-tasks/pinocchio#2296
    - Fix `examples/cassie-simulation.py` and `examples/talos-simulation.py` stack-of-tasks/pinocchio#2443
    - Fix build with CppAd 2024 stack-of-tasks/pinocchio#2459
    - Fix `pinocchio-test-cpp-mjcf` unittest with Boost 1.86 stack-of-tasks/pinocchio#2459
    - Fix `pinocchio-test-cpp-constraint-variants` uninitialized values stack-of-tasks/pinocchio#2459
    - Fix mixing library symbols between Pinocchio scalar bindings stack-of-tasks/pinocchio#2459
    - Fix bug for get{Joint,Frame}JacobianTimeVariation stack-of-tasks/pinocchio#2466

    ### Changed

    - Modernize python code base with ruff stack-of-tasks/pinocchio#2418
    - Does not create a root_joint frame from parsed models (urdf, mjcf and sdf) when no root joint is provided stack-of-tasks/pinocchio#2402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@olivier-roussel olivier-roussel olivier-roussel approved these changes

Assignees

@jorisv jorisv

Labels
build_all
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisv @olivier-roussel