Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjcf : Fix parsing of armature parameters #2477

Merged
merged 10 commits into from
Nov 13, 2024

Conversation

MegMll
Copy link
Collaborator

@MegMll MegMll commented Nov 13, 2024

This pr aims at correcting parsing of armature parameter available in mjcf models. As of now, mjcf provided only one value per joint, but in pinocchio armature is based on the model.nv.

In this pr, we modify how armature is parsed and use the pinocchio standard.

Another aim of this pr is to add support for default tag that does not have a class name. Until now, this was taken into account in the mjcf parser.

@MegMll MegMll requested a review from jorisv November 13, 2024 10:11
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

jcarpent
jcarpent previously approved these changes Nov 13, 2024
Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice Megan ;)

src/parsers/mjcf/mjcf-graph-geom.cpp Show resolved Hide resolved
src/parsers/mjcf/mjcf-graph.cpp Outdated Show resolved Hide resolved
@jorisv jorisv enabled auto-merge November 13, 2024 16:29
@jorisv jorisv merged commit 470ec5a into stack-of-tasks:devel Nov 13, 2024
22 checks passed
@MegMll MegMll deleted the fix/mjcf_armature branch November 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants