Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshcat_visualizer: force type of image paths to pathlib.Path #2478

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

abussy-aldebaran
Copy link
Contributor

I got the following error while using the meshcat visualizer:

/root/miniforge3/lib/python3.12/site-packages/pinocchio/visualize/meshcat_visualizer.py:916: UserWarning: Error while loading geometry object: LThigh_0
Error message:
'str' object has no attribute 'is_absolute'

Therefore I forced the type to Path. This is coherent with the Path(img_path_abs).open("rb") two lines below.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

nim65s
nim65s previously approved these changes Nov 15, 2024
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@nim65s
Copy link
Contributor

nim65s commented Nov 15, 2024

Can you add a little line in the CHANGELOG ?

@jcarpent jcarpent merged commit 0fc3e9d into stack-of-tasks:devel Nov 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants