Feature/ten point radial distortion fundamental matrix #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I91560f56ac54244bbac3e3e3b803a72f951f00ae
Change-Id: I145c836777a1784c0e300bc83e11224e0762947c
Change-Id: I02ec96771e7bf169f4801b65466206bfb56a716b
Change-Id: I690626d39839f64ef3531e3f5f3dda1cdb071cd2
Change-Id: I7d4df13713ab7a11dec37fcc49915c02166fc4b1
sweeneychris
reviewed
Jan 6, 2019
| Eigen::Matrix<double, 29, 1>& pr, | ||
| Eigen::Matrix<double, 2, 10>& sols); | ||
|
|
||
| template <typename Derived> |
There was a problem hiding this comment.
This comment was marked "resolved" but the style is not consistent with the clang format settings for the rest of Theia.
Change-Id: Ia71c61c2d8b2fe6881123b03e83a742bce728cf3
|
If you can rebase and run clang-format on the file I noted then this solver is good to check into the master branch |
|
Sure, if I find the time I will do it. Quite busy at the moment. I will also add the corresponding estimators for all solvers. :) |
Change-Id: If03d902babc1c313bea6909d32870d0478739bc2
|
Hey there! Sorry for being so MIA on this pull request. If you can fix the merge conflicts I am happy to accept this PR. Thanks so much for the work to add these solvers, and for the patience in working on the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ten point radial distortion solver proposed in: "Efficient Solution to the Epipolar Geometry for Radially Distorted Cameras", Z. Kukelova et al. ICCV 2015.
The original Matlab / C++ code is taken from: http://cmp.felk.cvut.cz/~hellej1/F10/F10-0.1.zip