vagrant: use LDFLAGS="-Wl,--no-as-needed" in sanitizer runs #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers" This reverts commit 800b173.
This reverts commit f86c6ce.
This reverts commit 8ff742b.
This reverts commit dfe84a2.
Since version 10, both gcc and clang started to ignore certain linker errors when compiling with -fsanitize=address. This eventually leads up to -lcrypt not being correctly propagated, but the fact is masked by the aforementioned issue. However, when the binary attempts to load a symbol from the libcrypt binary, it crashes since it's not linked correctly against it. Negating the -Wl,--as-needed used by default by -Wl,--no-as-needed seems to help in this case. See: https://bugzilla.redhat.com/show_bug.cgi?id=1827338#c3 systemd#247
mrc0mmand
force-pushed
the
workaround-issue-247
branch
from
f198ab4
to
18b7044
Compare
|
As long as it works I think it should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 10, both gcc and clang started to ignore certain linker errors
when compiling with -fsanitize=address. This eventually leads up to -lcrypt
not being correctly propagated, but the fact is masked by the aforementioned
issue. However, when the binary attempts to load a symbol from the libcrypt
binary, it crashes since it's not linked correctly against it.
Negating the -Wl,--as-needed used by default by -Wl,--no-as-needed seems to
help in this case.
See:
https://bugzilla.redhat.com/show_bug.cgi?id=1827338#c3
#247
/cc @evverx - this whole situation feels especially icky, hopefully I'm not missing something obvious :-)